chore: ListAssignments query returns categorized assignments#4363
Merged
Conversation
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
turboui/src/ReviewPage/stories/mockData.ts,calculateDueStatushas a redundantelse if (diffDays <= 1)branch immediately afterelse if (diffDays === 1)that can never be hit, and the logic for deciding what counts asdue_soonvsupcomingprobably needs to be revisited or simplified. - The new
urgentGroupsconstruction inturboui/src/ReviewPage/index.tsxre-groupsdueSoonandneedsReviewitems without applying the previous due-status/due-date sorting logic, which may change the ordering of items in the "Today’s work" section; consider explicitly sorting the combined list or relying on a shared ordering helper to preserve the intended urgency order.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `turboui/src/ReviewPage/stories/mockData.ts`, `calculateDueStatus` has a redundant `else if (diffDays <= 1)` branch immediately after `else if (diffDays === 1)` that can never be hit, and the logic for deciding what counts as `due_soon` vs `upcoming` probably needs to be revisited or simplified.
- The new `urgentGroups` construction in `turboui/src/ReviewPage/index.tsx` re-groups `dueSoon` and `needsReview` items without applying the previous due-status/due-date sorting logic, which may change the ordering of items in the "Today’s work" section; consider explicitly sorting the combined list or relying on a shared ordering helper to preserve the intended urgency order.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.