Skip to content

chore: ListAssignments query returns categorized assignments#4363

Merged
Rockyy174 merged 4 commits into
operately:mainfrom
Rockyy174:improve-assignments
Apr 15, 2026
Merged

chore: ListAssignments query returns categorized assignments#4363
Rockyy174 merged 4 commits into
operately:mainfrom
Rockyy174:improve-assignments

Conversation

@Rockyy174
Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • In turboui/src/ReviewPage/stories/mockData.ts, calculateDueStatus has a redundant else if (diffDays <= 1) branch immediately after else if (diffDays === 1) that can never be hit, and the logic for deciding what counts as due_soon vs upcoming probably needs to be revisited or simplified.
  • The new urgentGroups construction in turboui/src/ReviewPage/index.tsx re-groups dueSoon and needsReview items without applying the previous due-status/due-date sorting logic, which may change the ordering of items in the "Today’s work" section; consider explicitly sorting the combined list or relying on a shared ordering helper to preserve the intended urgency order.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In `turboui/src/ReviewPage/stories/mockData.ts`, `calculateDueStatus` has a redundant `else if (diffDays <= 1)` branch immediately after `else if (diffDays === 1)` that can never be hit, and the logic for deciding what counts as `due_soon` vs `upcoming` probably needs to be revisited or simplified.
- The new `urgentGroups` construction in `turboui/src/ReviewPage/index.tsx` re-groups `dueSoon` and `needsReview` items without applying the previous due-status/due-date sorting logic, which may change the ordering of items in the "Today’s work" section; consider explicitly sorting the combined list or relying on a shared ordering helper to preserve the intended urgency order.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
@Rockyy174 Rockyy174 merged commit c6441d1 into operately:main Apr 15, 2026
3 checks passed
@Rockyy174 Rockyy174 deleted the improve-assignments branch April 15, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant