chore: Remove deprecated Ownerships context#4367
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider making the migration safer by using
drop_if_exists table(:ownerships)so deployments in partially-migrated or inconsistent environments don’t fail if the table was already removed. - If you ever need to roll this back,
change/0with a baredrop table(:ownerships)is not reversible by Ecto; consider switching to explicitup/0/down/0callbacks so rollback behavior is clearly defined.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider making the migration safer by using `drop_if_exists table(:ownerships)` so deployments in partially-migrated or inconsistent environments don’t fail if the table was already removed.
- If you ever need to roll this back, `change/0` with a bare `drop table(:ownerships)` is not reversible by Ecto; consider switching to explicit `up/0`/`down/0` callbacks so rollback behavior is clearly defined.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
deeadd8 to
0718864
Compare
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.