Skip to content

chore: Remove deprecated Ownerships context#4367

Merged
Rockyy174 merged 3 commits into
operately:mainfrom
Rockyy174:remove-ownerships
Apr 16, 2026
Merged

chore: Remove deprecated Ownerships context#4367
Rockyy174 merged 3 commits into
operately:mainfrom
Rockyy174:remove-ownerships

Conversation

@Rockyy174
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider making the migration safer by using drop_if_exists table(:ownerships) so deployments in partially-migrated or inconsistent environments don’t fail if the table was already removed.
  • If you ever need to roll this back, change/0 with a bare drop table(:ownerships) is not reversible by Ecto; consider switching to explicit up/0/down/0 callbacks so rollback behavior is clearly defined.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider making the migration safer by using `drop_if_exists table(:ownerships)` so deployments in partially-migrated or inconsistent environments don’t fail if the table was already removed.
- If you ever need to roll this back, `change/0` with a bare `drop table(:ownerships)` is not reversible by Ecto; consider switching to explicit `up/0`/`down/0` callbacks so rollback behavior is clearly defined.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Rockyy174 Rockyy174 force-pushed the remove-ownerships branch 2 times, most recently from deeadd8 to 0718864 Compare April 16, 2026 15:23
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
@Rockyy174 Rockyy174 merged commit 2121043 into operately:main Apr 16, 2026
3 checks passed
@Rockyy174 Rockyy174 deleted the remove-ownerships branch April 16, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant