fix: Display complete/reopen actions in milestone notification

[Rockyy174]

No description provided.

[sourcery-ai]

Hey - I've left some high level feedback:

• Consider avoiding multiple Repo.preload calls for author and company by preloading nested associations in one call (e.g., Repo.preload(activity, author: :company)) to reduce unnecessary queries.
• The headline_text/2 function raises on unknown action values; it may be safer to handle nil or unexpected values gracefully (e.g., defaulting to the comment-only headline) to avoid runtime errors when comment_action is missing or malformed.
• The conditional logic that sets {excerpt_html, excerpt_text} could be made clearer by pattern matching on action (e.g., separate clauses for "none" vs others) instead of using an inline if, which would also avoid creating an unused map just for destructuring.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider avoiding multiple Repo.preload calls for author and company by preloading nested associations in one call (e.g., `Repo.preload(activity, author: :company)`) to reduce unnecessary queries.
- The `headline_text/2` function raises on unknown `action` values; it may be safer to handle `nil` or unexpected values gracefully (e.g., defaulting to the comment-only headline) to avoid runtime errors when `comment_action` is missing or malformed.
- The conditional logic that sets `{excerpt_html, excerpt_text}` could be made clearer by pattern matching on `action` (e.g., separate clauses for `"none"` vs others) instead of using an inline `if`, which would also avoid creating an unused map just for destructuring.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}