chore: Add tests for company transfer permissions#4396
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The permission snapshot helpers (
member_people/1,guest_people/1,permission_resources/0,resource_records/2) rely heavily on hard-coded names; consider threading through IDs from the factory-generated records instead to make the tests more robust against renames and localization changes. - The various
*_access_levelhelpers each embed their own access lookup logic (including a custom Ecto query for resource hubs); if there is a consolidated permission API (e.g., inAccess.Fetch), it would be cleaner and less fragile to use that consistently rather than duplicating access-resolution logic.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The permission snapshot helpers (`member_people/1`, `guest_people/1`, `permission_resources/0`, `resource_records/2`) rely heavily on hard-coded names; consider threading through IDs from the factory-generated records instead to make the tests more robust against renames and localization changes.
- The various `*_access_level` helpers each embed their own access lookup logic (including a custom Ecto query for resource hubs); if there is a consolidated permission API (e.g., in `Access.Fetch`), it would be cleaner and less fragile to use that consistently rather than duplicating access-resolution logic.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.