Skip to content

chore: Add amount and size limits to company transfer#4400

Merged
Rockyy174 merged 2 commits into
operately:mainfrom
Rockyy174:transfer-limits
Apr 24, 2026
Merged

chore: Add amount and size limits to company transfer#4400
Rockyy174 merged 2 commits into
operately:mainfrom
Rockyy174:transfer-limits

Conversation

@Rockyy174
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The with_package_limits/2 helper is duplicated across three test modules; consider extracting it into a shared test helper to keep the behavior consistent and reduce repetition.
  • Limits.get/1 and validate_value/2 will raise if a limit is missing from configuration via Map.fetch!/2; you may want to make this fail more defensively (e.g., return a tagged error or allow nil to mean 'no limit') to avoid hard crashes on misconfiguration.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The `with_package_limits/2` helper is duplicated across three test modules; consider extracting it into a shared test helper to keep the behavior consistent and reduce repetition.
- `Limits.get/1` and `validate_value/2` will raise if a limit is missing from configuration via `Map.fetch!/2`; you may want to make this fail more defensively (e.g., return a tagged error or allow `nil` to mean 'no limit') to avoid hard crashes on misconfiguration.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
@Rockyy174 Rockyy174 merged commit df54aec into operately:main Apr 24, 2026
3 checks passed
@Rockyy174 Rockyy174 deleted the transfer-limits branch April 24, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant