fix: Company transfer works with S3 compatible services

[Rockyy174]

No description provided.

[sourcery-ai]

Hey - I've left some high level feedback:

• In S3Config.request_config/0, request_scheme/0 assumes scheme/0 always returns a binary; if OPERATELY_STORAGE_S3_SCHEME is unset (e.g. standard AWS S3), this will raise, so it would be safer to either make scheme/0 non-nil in all configs or have request_scheme/0 handle nil by returning a sensible default or omitting the option.
• The new catch clauses in ExportWorker.perform/1 and ImportWorker.perform/1 trap all thrown values as well as exits, which might unintentionally convert normal throw/catch control flow into logged failures; if you only need to handle process exits, consider narrowing this to catch :exit, reason -> ....

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `S3Config.request_config/0`, `request_scheme/0` assumes `scheme/0` always returns a binary; if `OPERATELY_STORAGE_S3_SCHEME` is unset (e.g. standard AWS S3), this will raise, so it would be safer to either make `scheme/0` non-nil in all configs or have `request_scheme/0` handle `nil` by returning a sensible default or omitting the option.
- The new `catch` clauses in `ExportWorker.perform/1` and `ImportWorker.perform/1` trap all thrown values as well as exits, which might unintentionally convert normal `throw`/`catch` control flow into logged failures; if you only need to handle process exits, consider narrowing this to `catch :exit, reason -> ...`.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}