Skip to content

chore: API supports cli defaults#4477

Merged
Rockyy174 merged 12 commits into
operately:mainfrom
Rockyy174:update-mutations
May 14, 2026
Merged

chore: API supports cli defaults#4477
Rockyy174 merged 12 commits into
operately:mainfrom
Rockyy174:update-mutations

Conversation

@Rockyy174
Copy link
Copy Markdown
Collaborator

fixes #4456.

Rockyy174 added 11 commits May 14, 2026 09:47
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • In TurboConnect.InputDefaults.effective_default/2 you always prefer :external_default when present for external APIs, even if its value is nil, which will shadow a non-nil :default; consider treating a nil external_default as missing so the internal default still applies.
  • The new CLI E2E step modules for documents/goals/projects/spaces/links share a lot of duplicated setup and assertion logic; consider extracting shared helpers (e.g., for auth+token setup and subscription_list assertions) to keep these tests easier to maintain.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In TurboConnect.InputDefaults.effective_default/2 you always prefer :external_default when present for external APIs, even if its value is nil, which will shadow a non-nil :default; consider treating a nil external_default as missing so the internal default still applies.
- The new CLI E2E step modules for documents/goals/projects/spaces/links share a lot of duplicated setup and assertion logic; consider extracting shared helpers (e.g., for auth+token setup and subscription_list assertions) to keep these tests easier to maintain.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
@Rockyy174 Rockyy174 merged commit 20e7bbb into operately:main May 14, 2026
3 checks passed
@Rockyy174 Rockyy174 deleted the update-mutations branch May 14, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI: create_discussion should notify space members by default (match UI behavior)

1 participant