Fix deploy job#119
Merged
Merged
Conversation
liquid 4.0.3 calls String#tainted? which was removed in Ruby 3.2+, causing the Jekyll build to fail with NoMethodError. Upgrading to 4.0.4 removes that call. Also add .devenv/scripts/ci/run-act.sh to test the workflow locally with act. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix the GitHub Pages deploy workflow for the Jekyll site by updating the Ruby toolchain and aligning gem/bundler versions used during the build.
Changes:
- Update
ruby/setup-rubyaction pin and bump the CI Ruby version used for the Jekyll build. - Refresh lockfile versions (Liquid patch bump; Bundler version bump in
BUNDLED WITH). - Add a helper script to run the Jekyll workflow locally via
act.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Gemfile.lock |
Updates locked gem/Bundler versions used during CI builds. |
.github/workflows/jekyll.yml |
Updates Ruby setup action pin and Ruby version for the Pages build job. |
.devenv/scripts/ci/run-act.sh |
Adds a convenience script to run the build job locally with act. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| uses: ruby/setup-ruby@c4e5b1316158f92e3d49443a9d58b31d25ac0f8f | ||
| with: | ||
| ruby-version: '3.1' # Not needed with a .ruby-version file | ||
| ruby-version: '3.3.11' # Not needed with a .ruby-version file |
There was a problem hiding this comment.
The inline note says ruby-version is “Not needed with a .ruby-version file”, but the repository doesn’t currently include a .ruby-version. Either add a .ruby-version (to keep local dev/CI in sync) or adjust/remove this comment to avoid misleading future edits.
Suggested change
| ruby-version: '3.3.11' # Not needed with a .ruby-version file | |
| ruby-version: '3.3.11' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.