Skip to content

Conversation

@camilamacedo86
Copy link
Collaborator

@camilamacedo86 camilamacedo86 commented Jun 20, 2021

Description

  • change rules of custom deprecated dashboards and improve reports generated modules
  • fix check for custom scorecards
  • improve readme
  • improve makefile targets and hack generated modules
  • remove todo cleanup to centralize the bundle struct new
  • remove full generation of packages and channels reports to reduce the required time ( we might able to remove these reports in follow-ups and replace them with custom reports with specific rules and generated from the bundles JSON results. After introduces the custom dashboards into audit this options seems no longer bring too much value and could better be placed in customs dashs )

@coveralls
Copy link

Pull Request Test Coverage Report for Build 954051477

  • 0 of 376 (0.0%) changed or added relevant lines in 13 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.04%) to 1.048%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/reports/channels/report.go 0 3 0.0%
pkg/reports/packages/data.go 0 6 0.0%
pkg/actions/run_scorecard.go 0 7 0.0%
pkg/reports/channels/data.go 0 7 0.0%
pkg/actions/get_bundle.go 0 11 0.0%
pkg/removed_apis.go 0 14 0.0%
pkg/actions/extract_index.go 0 17 0.0%
pkg/reports/bundles/data.go 0 21 0.0%
pkg/reports/packages/report.go 0 23 0.0%
pkg/reports/bundles/report.go 0 37 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/reports/packages/data.go 1 0%
pkg/reports/bundles/report.go 2 0%
pkg/reports/packages/report.go 2 0%
Totals Coverage Status
Change from base Build 944115639: 0.04%
Covered Lines: 18
Relevant Lines: 1717

💛 - Coveralls

@camilamacedo86
Copy link
Collaborator Author

camilamacedo86 commented Jun 20, 2021

HI @jmccormick2001 , @gallettilance, @bentito, @bparees

I am moving forward here for you are able to easily check and review the changes applied on the custom dashboards.
We need to check how and add a preview for the index HTML page. (low priority - follow ups)

@camilamacedo86 camilamacedo86 merged commit 7a724e1 into operator-framework:main Jun 20, 2021
@camilamacedo86 camilamacedo86 deleted the changes branch June 20, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants