This repository was archived by the owner on Sep 21, 2020. It is now read-only.
Add propriate permission for the sample memcachedoperator#38
Merged
hasbro17 merged 1 commit intooperator-framework:masterfrom May 23, 2019
Merged
Add propriate permission for the sample memcachedoperator#38hasbro17 merged 1 commit intooperator-framework:masterfrom
hasbro17 merged 1 commit intooperator-framework:masterfrom
Conversation
openshift-ci-robot
added
the
size/M
hasbro17
approved these changes
May 23, 2019
Collaborator
hasbro17
left a comment
hasbro17
left a comment
There was a problem hiding this comment.
@jianzhangbjz Thanks for the fix. Hopefully we can avoid this in the future by just having users generate the CSV themselves via the SDK in #37
LGTM
Member
Author
|
@hasbro17 Yes, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title, please have a review, thanks!