Skip to content

feat: Reconcile utils #3075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
csviri wants to merge 26 commits into
base: next
Choose a base branch
from
Open

feat: Reconcile utils #3075

csviri wants to merge 26 commits into from

Conversation

@csviri
Copy link
Collaborator

@csviri csviri commented Dec 1, 2025 •
edited
Loading

  • The PR adds utility that provides methods to update resources using comparable resource versions
  • Integrates this utility to the core of the framework (thus simplifying ReconciliationDispatcher)
    • note that this introduces a change in the behavior for the UpdateControl.patchStatus (and others), since it won't trigger the reconiliation for the event in that update.
  • Renames former ReconcilerUtils to ReconcilerUtilsInternal, this is breaking but that utils was never advertised for non-internal usage
  • Includes also fixes for ControllerEventSource event filtering

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 4, 2025
shawkins and others added 18 commits December 22, 2025 10:55
@shawkins @csviri
Annotation removal using locking (operator-framework#3015)
170f974 
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@csviri
improve: complete comparable resource version configs (operator-frame…
5bd4f9c 
…work#3027)

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
chore: change version to 5.2.0-SNAPSHOT (operator-framework#2995)
f82a799 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@shawkins @csviri
Annotation removal using locking (operator-framework#3015)
d82657f 
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@csviri
feat: comparable resource version utils
1f5c845
@csviri
wip
c2d62d9 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
fixes
056fd2c 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
fix
52ef176 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
wip
49afdd3
@csviri
wip
43fbdae
@csviri
wip
e0e838e
@csviri
wip
0a5628f
@csviri
wip
1356e4c
@csviri
wip
660e3ad
@csviri
feat: comparable resource version utils
ef7903f
@csviri
merge
5a3c524 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
wip
bf3de16
@csviri
wip
d54cd39
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 22, 2025
@csviri
wip
67d4127 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri csviri linked an issue Dec 22, 2025 that may be closed by this pull request
Utilities to update and cache resources also for secondary resources with comparable resource version #3011
Open
@csviri
wip
6aa48a7 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
wip
4064492 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri csviri marked this pull request as ready for review December 22, 2025 13:53
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 22, 2025
@openshift-ci openshift-ci bot requested review from metacosm and xstefank December 22, 2025 13:54
csviri
csviri commented Dec 22, 2025
View reviewed changes
...-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/ReconcileUtils.java
import static io.javaoperatorsdk.operator.processing.KubernetesResourceUtils.getUID;
import static io.javaoperatorsdk.operator.processing.KubernetesResourceUtils.getVersion;

public class ReconcileUtils {
Copy link
Collaborator Author

@csviri csviri Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As alternative names was thinking about ReconcilerUtils and ReconciliationUtils. What do you think @metacosm @shawkins @xstefank

@csviri csviri requested a review from shawkins December 22, 2025 13:55
@csviri
wip
c6cefac 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
wip
c89fcf4 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
wip
baab53b 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
wip
5667085 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
wip
863ecde 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@metacosm metacosm Awaiting requested review from metacosm

@xstefank xstefank Awaiting requested review from xstefank

@shawkins shawkins Awaiting requested review from shawkins

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Utilities to update and cache resources also for secondary resources with comparable resource version

3 participants

@csviri @openshift-merge-robot @shawkins