-
Notifications
You must be signed in to change notification settings - Fork 236
fix: grammar issue #3083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: grammar issue #3083
Conversation
csviri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update also the docs.
Signed-off-by: Chris Laprun <metacosm@gmail.com>
|
There is one more here:
|
I was about to change these as well (there's another one in that file as well, iirc) but since it's part of the blog, I decided against changing it but we should indeed mention it in the release notes and/or blog for 5.2.1. |
I think we should do it also, but I can do it as separate PR if you see it better that way, just to don't make confusion around it if some reads the blog. |
If we agree that the blog should be modified, I can do it here. |
I would vote for that, thx! |
Signed-off-by: Chris Laprun metacosm@gmail.com