Skip to content

Conversation

@metacosm
Copy link
Collaborator

@metacosm metacosm commented Dec 2, 2025

Signed-off-by: Chris Laprun metacosm@gmail.com

@metacosm metacosm self-assigned this Dec 2, 2025
@metacosm metacosm requested review from csviri and xstefank December 2, 2025 13:22
Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update also the docs.

Signed-off-by: Chris Laprun <metacosm@gmail.com>
@metacosm metacosm changed the title fix: typos fix: grammar issue Dec 2, 2025
@metacosm metacosm requested a review from csviri December 2, 2025 13:39
@csviri
Copy link
Collaborator

csviri commented Dec 2, 2025

There is one more here:

@ControllerConfiguration(triggerReconcilerOnAllEvent = true)

@metacosm
Copy link
Collaborator Author

metacosm commented Dec 2, 2025

There is one more here:

@ControllerConfiguration(triggerReconcilerOnAllEvent = true)

I was about to change these as well (there's another one in that file as well, iirc) but since it's part of the blog, I decided against changing it but we should indeed mention it in the release notes and/or blog for 5.2.1.

@csviri
Copy link
Collaborator

csviri commented Dec 2, 2025

There is one more here:

@ControllerConfiguration(triggerReconcilerOnAllEvent = true)

I was about to change these as well (there's another one in that file as well, iirc) but since it's part of the blog, I decided against changing it but we should indeed mention it in the release notes and/or blog for 5.2.1.

I think we should do it also, but I can do it as separate PR if you see it better that way, just to don't make confusion around it if some reads the blog.

@metacosm
Copy link
Collaborator Author

metacosm commented Dec 2, 2025

There is one more here:

@ControllerConfiguration(triggerReconcilerOnAllEvent = true)

I was about to change these as well (there's another one in that file as well, iirc) but since it's part of the blog, I decided against changing it but we should indeed mention it in the release notes and/or blog for 5.2.1.

I think we should do it also, but I can do it as separate PR if you see it better that way, just to don't make confusion around it if some reads the blog.

If we agree that the blog should be modified, I can do it here.

@csviri
Copy link
Collaborator

csviri commented Dec 2, 2025

There is one more here:

@ControllerConfiguration(triggerReconcilerOnAllEvent = true)

I was about to change these as well (there's another one in that file as well, iirc) but since it's part of the blog, I decided against changing it but we should indeed mention it in the release notes and/or blog for 5.2.1.

I think we should do it also, but I can do it as separate PR if you see it better that way, just to don't make confusion around it if some reads the blog.

If we agree that the blog should be modified, I can do it here.

I would vote for that, thx!

[skip ci]

Signed-off-by: Chris Laprun <metacosm@gmail.com>
@metacosm metacosm merged commit fe2a54c into main Dec 2, 2025
1 check passed
@metacosm metacosm deleted the fix-typo branch December 2, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants