Skip to content

Conversation

@csviri
Copy link
Collaborator

@csviri csviri commented Jan 27, 2026

This should not be user facing. At least not in any obvious scenerio.

@openshift-ci openshift-ci bot requested review from metacosm and xstefank January 27, 2026 11:15
@csviri csviri linked an issue Jan 27, 2026 that may be closed by this pull request
5 tasks
This should not be user facing. At least not in any obvious scenerio.

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri csviri force-pushed the compare-to-internal branch from a1fe12d to 07e0324 Compare January 27, 2026 11:24
@metacosm
Copy link
Collaborator

Split on this. On the one hand, I agree that there's probably not much need to expose this. On the other hand, I could see users wanting to perform these comparisons as well and we might as well let them use our implementation. That said, they could call ReconcileUtilsInternal anyway?

@csviri
Copy link
Collaborator Author

csviri commented Jan 27, 2026

Split on this. On the one hand, I agree that there's probably not much need to expose this. On the other hand, I could see users wanting to perform these comparisons as well and we might as well let them use our implementation. That said, they could call ReconcileUtilsInternal anyway?

Yeah, that is the idea, so basically I don't see any use case when users should call it, and therefore hiding it, on the other hand if they are doing some very specific operation nothing stops them to using it from the internal. This approach felt a bit more correct, but up to debate.

Copy link
Collaborator

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issue with this. But maybe some users might be discouraged by the word internal in the name, but it is a public class, so not a big issue.

@csviri csviri merged commit f105902 into operator-framework:next Jan 28, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comparable Resource Versions in Kubernetes

3 participants