Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes the Maven compiler configuration by replacing the older maven.compiler.source and maven.compiler.target properties with the recommended maven.compiler.release property. This ensures proper cross-compilation by setting source, target, and bootstrap classpath simultaneously, which is the best practice for Maven Compiler Plugin 3.6+.
Changes:
- Updated the root pom.xml to use
maven.compiler.releaseinstead of separate source and target properties
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Chris Laprun <metacosm@gmail.com>
metacosm
force-pushed
the
fix-java-version
branch
from
6f2da0d to
6d9dc92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Laprun metacosm@gmail.com