Skip to content

fix: update Maven wrapper to Maven 3.9.12 and use it in CI#3281

Merged
csviri merged 1 commit intooperator-framework:mainfrom
xstefank:maven-wrapper
Apr 9, 2026
Merged

fix: update Maven wrapper to Maven 3.9.12 and use it in CI#3281
csviri merged 1 commit intooperator-framework:mainfrom
xstefank:maven-wrapper

Conversation

@xstefank
Copy link
Copy Markdown
Collaborator

@xstefank xstefank commented Apr 8, 2026

Signed-off-by: xstefank <xstefank122@gmail.com>
Copilot AI review requested due to automatic review settings April 8, 2026 14:49
@openshift-ci openshift-ci bot requested review from csviri and metacosm April 8, 2026 14:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Maven wrapper infrastructure to Maven 3.9.12 and modernizes the wrapper scripts from version 3.1.0 to 3.3.4. The key architectural change is moving from a JAR-based downloader to script-based Maven distribution downloading. The CI workflows are updated to consistently use the wrapper (./mvnw) instead of relying on pre-installed Maven.

Changes:

  • Updated Maven version from 3.8.4 to 3.9.12 in wrapper configuration
  • Rewrote mvnw shell script with improved error handling, platform detection, and download capabilities
  • Rewrote mvnw.cmd as a hybrid batch/PowerShell script for better Windows compatibility
  • Removed Java-based MavenWrapperDownloader.java (now handled by scripts)
  • Updated maven-wrapper.properties to reference Maven 3.9.12 and added metadata fields
  • Updated 4 CI workflow files to use ./mvnw instead of direct mvn commands

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
mvnw Complete rewrite with improved error handling, platform detection, and SHA-256 validation support
mvnw.cmd Hybrid batch/PowerShell implementation with direct Maven distribution downloading
.mvn/wrapper/maven-wrapper.properties Updated to Maven 3.9.12, simplified format, added wrapper metadata
.mvn/wrapper/MavenWrapperDownloader.java Removed (functionality now in scripts)
.github/workflows/snapshot-releases.yml Updated to use ./mvnw wrapper
.github/workflows/release-project-in-dir.yml Updated to use ./mvnw wrapper
.github/workflows/e2e-test.yml Updated to use ./mvnw wrapper

# Required ENV vars:
# ------------------
# JAVA_HOME - location of a JDK home dir
# Apache Maven Wrapper startup batch script, version 3.3.4
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment on line 22 incorrectly refers to this as a "batch script" when this file is the Unix/Linux shell script wrapper. The comment should say "shell script" or "startup script" instead of "batch script". The batch script is in mvnw.cmd.

Suggested change
# Apache Maven Wrapper startup batch script, version 3.3.4
# Apache Maven Wrapper startup shell script, version 3.3.4

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thx!

@csviri csviri merged commit 32e2ae3 into operator-framework:main Apr 9, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants