improve: log diagnostic for remote deployment junit extension#3306
Open
csviri wants to merge 1 commit intooperator-framework:mainfrom
Open
improve: log diagnostic for remote deployment junit extension#3306csviri wants to merge 1 commit intooperator-framework:mainfrom
csviri wants to merge 1 commit intooperator-framework:mainfrom
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
csviri
changed the title
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
Contributor
There was a problem hiding this comment.
Pull request overview
Adds richer diagnostics when a cluster-deployed operator times out during deployment, to make remote E2E failures easier to debug.
Changes:
- Catch
KubernetesClientTimeoutExceptionduringwaitUntilReadyand emit diagnostics before rethrowing. - Add
logDiagnosticInfo(...)to report deployments, pods, container statuses, related events, and recent pod logs on timeout.
Comment on lines
+234
to
+236
| " Could not retrieve logs for pod '{}': {}", | ||
| pod.getMetadata().getName(), | ||
| logEx.getMessage()); |
There was a problem hiding this comment.
When pod log retrieval fails, this only logs the exception message and drops the stack trace, which makes diagnosing client/auth/network issues harder. Consider logging the exception itself as the last argument (similar to the diagEx handling below) so the full cause is available when needed.
Suggested change
| " Could not retrieve logs for pod '{}': {}", | |
| pod.getMetadata().getName(), | |
| logEx.getMessage()); | |
| " Could not retrieve logs for pod '{}'", | |
| pod.getMetadata().getName(), | |
| logEx); |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Attila Mészáros a_meszaros@apple.com