fix: remove MultiOwnerDependentTriggeringIT#3318
Open
csviri wants to merge 1 commit intooperator-framework:mainfrom
Open
fix: remove MultiOwnerDependentTriggeringIT#3318csviri wants to merge 1 commit intooperator-framework:mainfrom
csviri wants to merge 1 commit intooperator-framework:mainfrom
Conversation
Note that although the test was passing it had multiple issues. Since this is not properly supported removing the IT so it does not make confusion. Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the unsupported “multi-owner dependent resource” integration test to avoid confusion, along with its supporting test-only custom resource, reconciler, dependent resource, and spec model classes.
Changes:
- Deleted
MultiOwnerDependentTriggeringITintegration test for multi-owner dependent triggering behavior. - Removed the associated test reconciler, dependent ConfigMap implementation, and CR model classes under the same package.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/multipleupdateondependent/MultipleOwnerDependentSpec.java |
Removes spec POJO used only by the deleted IT. |
operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/multipleupdateondependent/MultipleOwnerDependentReconciler.java |
Removes test reconciler used only by the deleted IT. |
operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/multipleupdateondependent/MultipleOwnerDependentCustomResource.java |
Removes test CustomResource type used only by the deleted IT. |
operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/multipleupdateondependent/MultipleOwnerDependentConfigMap.java |
Removes dependent resource implementation used only by the deleted IT. |
operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/multipleupdateondependent/MultiOwnerDependentTriggeringIT.java |
Removes the integration test that was passing but considered unsupported/problematic. |
xstefank
reviewed
Apr 27, 2026
Collaborator
xstefank
left a comment
xstefank
left a comment
There was a problem hiding this comment.
I don't understand the reasoning why removing and not fixing it?
Collaborator
Author
It would be quite an effort to fix it, that would be feature in dependent resources. Feel free to take a look at it, we can have a call to explore. |
metacosm
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that although the test was passing it had multiple issues.
Since this is not properly supported removing the IT so it does not make confusion.
Signed-off-by: Attila Mészáros a_meszaros@apple.com