fix: revert breaking constructor change in InformerConfiguration#3361
Merged
Conversation
Collaborator
xstefank
commented
May 18, 2026
xstefank
commented
Signed-off-by: xstefank <xstefank122@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores a previously removed constructor parameter on InformerConfiguration to undo a breaking API/signature change and updates the copy-builder path accordingly.
Changes:
- Reintroduces the
ghostResourceCacheCheckIntervalparameter in the protectedInformerConfigurationconstructor (marked inline as slated for removal). - Updates
builder(InformerConfiguration<R> original)to pass a value (null) for the reintroduced parameter.
Comment on lines
71
to
75
| FieldSelector fieldSelector, | ||
| Boolean comparableResourceVersions) { | ||
| Boolean comparableResourceVersions, | ||
| // TODO for removal in major release | ||
| Duration ghostResourceCacheCheckInterval) { | ||
| this(resourceClass); |
Comment on lines
120
to
+124
| original.itemStore, | ||
| original.informerListLimit, | ||
| original.fieldSelector, | ||
| original.comparableResourceVersions) | ||
| original.comparableResourceVersions, | ||
| null) |
Collaborator
|
Do we really need this, also on protected constructor? |
Collaborator
Author
|
It breaks QOSDK. And it is a public API. Users can also extend it and call the constructor. Not possible to do this in micro release. |
csviri
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.