Skip to content

Conversation

@tmshort
Copy link
Contributor

@tmshort tmshort commented Oct 23, 2025

This removes operatorControllerFeatures and catalogdFeatures in favor of options.<component>.features.{enabled|disabled}.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

This removes `operatorControllerFeatures` and `catalogdFeatures` in favor
of `options.<component>.features.{enabled|disabled}`.

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort requested a review from a team as a code owner October 23, 2025 18:07
@netlify
Copy link

netlify bot commented Oct 23, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 0c477ba
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68fa6ed0c62f6d000822fc27
😎 Deploy Preview https://deploy-preview-2285--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.19%. Comparing base (926d57e) to head (0c477ba).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2285      +/-   ##
==========================================
+ Coverage   70.41%   71.19%   +0.78%     
==========================================
  Files          90       90              
  Lines        8794     6995    -1799     
==========================================
- Hits         6192     4980    -1212     
+ Misses       2189     1601     -588     
- Partials      413      414       +1     
Flag Coverage Δ
e2e 45.91% <ø> (+0.93%) ⬆️
experimental-e2e 14.72% <ø> (+0.61%) ⬆️
unit 58.79% <ø> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 25d3e43 into operator-framework:main Oct 23, 2025
24 checks passed
@tmshort tmshort deleted the cleanup-deprecated-feature-settings branch October 24, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants