Skip to content

Conversation

@tmshort
Copy link
Contributor

@tmshort tmshort commented Oct 24, 2025

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort requested a review from a team as a code owner October 24, 2025 14:12
@netlify
Copy link

netlify bot commented Oct 24, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 5b4aadf
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68fb8960fdc4a200083e37e5
😎 Deploy Preview https://deploy-preview-2287--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.28%. Comparing base (25d3e43) to head (5b4aadf).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2287   +/-   ##
=======================================
  Coverage   71.28%   71.28%           
=======================================
  Files          90       90           
  Lines        7003     7003           
=======================================
  Hits         4992     4992           
  Misses       1599     1599           
  Partials      412      412           
Flag Coverage Δ
e2e 45.88% <ø> (ø)
experimental-e2e 14.70% <ø> (+0.11%) ⬆️
unit 58.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@pedjak pedjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2025
@tmshort
Copy link
Contributor Author

tmshort commented Oct 24, 2025

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pedjak, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit f71870d into operator-framework:main Oct 24, 2025
28 of 29 checks passed
@tmshort tmshort deleted the claude branch October 24, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants