-
Notifications
You must be signed in to change notification settings - Fork 68
🌱 Revert Single/Own Namespace GA promotion #2292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -6,14 +6,16 @@ | |||||
| set -e | ||||||
| trap 'echo "Demo ran into error"; trap - SIGTERM && kill -- -$$; exit 1' ERR SIGINT SIGTERM EXIT | ||||||
|
|
||||||
| # install standard CRDs | ||||||
| echo "Install standard CRDs..." | ||||||
| kubectl apply -f "$(dirname "${BASH_SOURCE[0]}")/../../manifests/standard.yaml" | ||||||
| # install experimental CRDs with config field support | ||||||
| kubectl apply -f "$(dirname "${BASH_SOURCE[0]}")/../../manifests/experimental.yaml" | ||||||
|
|
||||||
| # wait for standard CRDs to be available | ||||||
| # wait for experimental CRDs to be available | ||||||
| kubectl wait --for condition=established --timeout=60s crd/clusterextensions.olm.operatorframework.io | ||||||
|
|
||||||
| # Ensure controller is healthy | ||||||
| # enable 'SingleOwnNamespaceInstallSupport' feature gate | ||||||
| kubectl patch deployment -n olmv1-system operator-controller-controller-manager --type='json' -p='[{"op": "add", "path": "/spec/template/spec/containers/0/args/-", "value": "--feature-gates=SingleOwnNamespaceInstallSupport=true"}]' | ||||||
|
|
||||||
| # wait for operator-controller to become available | ||||||
| kubectl rollout status -n olmv1-system deployment/operator-controller-controller-manager | ||||||
|
|
||||||
| # create install namespace | ||||||
|
|
@@ -58,6 +60,17 @@ kubectl delete clusterextension argocd-operator --ignore-not-found=true | |||||
| kubectl delete namespace argocd-system argocd --ignore-not-found=true | ||||||
| kubectl delete clusterrolebinding argocd-installer-crb --ignore-not-found=true | ||||||
|
|
||||||
| # remove feature gate from deployment | ||||||
| echo "Removing feature gate from operator-controller..." | ||||||
| kubectl patch deployment -n olmv1-system operator-controller-controller-manager --type='json' -p='[{"op": "remove", "path": "/spec/template/spec/containers/0/args", "value": "--feature-gates=SingleOwnNamespaceInstallSupport=true"}]' || true | ||||||
|
||||||
| kubectl patch deployment -n olmv1-system operator-controller-controller-manager --type='json' -p='[{"op": "remove", "path": "/spec/template/spec/containers/0/args", "value": "--feature-gates=SingleOwnNamespaceInstallSupport=true"}]' || true | |
| kubectl patch deployment -n olmv1-system operator-controller-controller-manager --type='json' -p='[{"op": "remove", "path": "/spec/template/spec/containers/0/args/-"}]' || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The kubectl patch 'remove' operation should not include a 'value' field. The 'remove' operation in JSON Patch only requires the 'path' field, and including 'value' is invalid. This will cause the patch to fail (silently due to '|| true'). The correct operation should remove the specific argument from the array by index or use a different approach.