-
Notifications
You must be signed in to change notification settings - Fork 68
🌱 Add regression test for bundles with webhooks #2294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add regression test for bundles with webhooks #2294
Conversation
Signed-off-by: Per G. da Silva <pegoncal@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds regression test data for webhook operator bundle conversion functionality. It introduces a new test case that validates the rendering of a webhook operator bundle (v0.0.5) containing all types of webhooks: conversion webhooks, mutating admission webhooks, and validating admission webhooks.
Key Changes:
- Added webhook-operator.v0.0.5 bundle test data with conversion, mutating, and validating webhooks
- Added expected manifest outputs showing how the bundle is converted to plain Kubernetes resources
- Extended the test generator to include the new webhook test case
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| generate-manifests.go | Added new "Webhooks" test case configuration with webhook-system namespace |
| bundles/webhook-operator.v0.0.5/* | New bundle source files including CSV, CRD, and metadata |
| expected-manifests/webhook-operator.v0.0.5/all-webhook-types/* | Generated Kubernetes manifests from bundle conversion (RBAC, CRD, deployments, services, webhook configs) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.../all-webhook-types/04_customresourcedefinition_webhooktests.webhook.operators.coreos.io.yaml
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2294 +/- ##
==========================================
- Coverage 71.28% 71.23% -0.06%
==========================================
Files 90 90
Lines 7003 7008 +5
==========================================
Hits 4992 4992
- Misses 1599 1604 +5
Partials 412 412
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catcher 🥇
/lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
314e59f
into
operator-framework:main
Description
We've updated the registry+v1 renderer to support bundles with webhook definitions but forgot to add a regression test.
This PR adds that regression test using a bundle for the webhook-operator used for e2e testing.
Reviewer Checklist