Skip to content

Conversation

@perdasilva
Copy link
Contributor

Description

We've updated the registry+v1 renderer to support bundles with webhook definitions but forgot to add a regression test.
This PR adds that regression test using a bundle for the webhook-operator used for e2e testing.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Per G. da Silva <pegoncal@redhat.com>
@perdasilva perdasilva requested a review from a team as a code owner October 31, 2025 14:03
Copilot AI review requested due to automatic review settings October 31, 2025 14:03
@openshift-ci openshift-ci bot requested review from bentito and tmshort October 31, 2025 14:03
@netlify
Copy link

netlify bot commented Oct 31, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit e6b5cc6
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6904c1a832a1830008c92887
😎 Deploy Preview https://deploy-preview-2294--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds regression test data for webhook operator bundle conversion functionality. It introduces a new test case that validates the rendering of a webhook operator bundle (v0.0.5) containing all types of webhooks: conversion webhooks, mutating admission webhooks, and validating admission webhooks.

Key Changes:

  • Added webhook-operator.v0.0.5 bundle test data with conversion, mutating, and validating webhooks
  • Added expected manifest outputs showing how the bundle is converted to plain Kubernetes resources
  • Extended the test generator to include the new webhook test case

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

File Description
generate-manifests.go Added new "Webhooks" test case configuration with webhook-system namespace
bundles/webhook-operator.v0.0.5/* New bundle source files including CSV, CRD, and metadata
expected-manifests/webhook-operator.v0.0.5/all-webhook-types/* Generated Kubernetes manifests from bundle conversion (RBAC, CRD, deployments, services, webhook configs)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.23%. Comparing base (760855f) to head (e6b5cc6).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
test/regression/convert/generate-manifests.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2294      +/-   ##
==========================================
- Coverage   71.28%   71.23%   -0.06%     
==========================================
  Files          90       90              
  Lines        7003     7008       +5     
==========================================
  Hits         4992     4992              
- Misses       1599     1604       +5     
  Partials      412      412              
Flag Coverage Δ
e2e 45.88% <ø> (-0.05%) ⬇️
experimental-e2e 14.70% <ø> (+0.11%) ⬆️
unit 58.83% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catcher 🥇

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2025
@tmshort
Copy link
Contributor

tmshort commented Oct 31, 2025

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 314e59f into operator-framework:main Oct 31, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants