Skip to content

Conversation

@pedjak
Copy link
Contributor

@pedjak pedjak commented Oct 31, 2025

Description

Its presence has forced the BoxCutter applier to believe that resources differ from
those existing on the cluster and thus new revisions are created indefinitely on each reconcile
when trying to install webhook-operator package.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

…st resources

It presence has forced the BoxCutter applier to believe that resources differ from
those existing on the cluster and thus new revisions are created indefinitely on each reconcile
when trying to install webhook-operator package.
Copilot AI review requested due to automatic review settings October 31, 2025 17:51
@pedjak pedjak requested a review from a team as a code owner October 31, 2025 17:51
@netlify
Copy link

netlify bot commented Oct 31, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 1081521
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6904f734f206ed00089dfc1d
😎 Deploy Preview https://deploy-preview-2295--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pedjak pedjak changed the title Remove creationTimestamp and status fields from webhook-operator test resources 🐛 Remove creationTimestamp and status fields from webhook-operator test resources Oct 31, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR cleans up Kubernetes manifest files by removing auto-generated and runtime fields that should not be committed to source control. These fields (creationTimestamp, empty status sections, and null spec values) are typically populated by Kubernetes at runtime.

  • Removed creationTimestamp: null from CRD and ClusterRole metadata
  • Removed empty status section from CustomResourceDefinition
  • Removed "spec": null entries from ClusterServiceVersion example manifests

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
webhook.operators.coreos.io_webhooktests.yaml Removed creationTimestamp field from metadata and empty status section from CRD definition
webhook-operator.clusterserviceversion.yaml Removed "spec": null entries from example resource definitions for v1 and v2 API versions
webhook-operator-metrics-reader_rbac.authorization.k8s.io_v1beta1_clusterrole.yaml Removed creationTimestamp field from ClusterRole metadata

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.38%. Comparing base (8bda126) to head (1081521).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2295      +/-   ##
==========================================
+ Coverage   71.28%   74.38%   +3.09%     
==========================================
  Files          90       90              
  Lines        7003     7003              
==========================================
+ Hits         4992     5209     +217     
+ Misses       1599     1385     -214     
+ Partials      412      409       -3     
Flag Coverage Δ
e2e 45.85% <ø> (-0.04%) ⬇️
experimental-e2e 48.23% <ø> (+33.63%) ⬆️
unit 58.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 1572d1c into operator-framework:main Oct 31, 2025
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants