-
Notifications
You must be signed in to change notification settings - Fork 68
🐛 Remove creationTimestamp and status fields from webhook-operator test resources
#2295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Remove creationTimestamp and status fields from webhook-operator test resources
#2295
Conversation
…st resources It presence has forced the BoxCutter applier to believe that resources differ from those existing on the cluster and thus new revisions are created indefinitely on each reconcile when trying to install webhook-operator package.
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
creationTimestamp and status fields from webhook-operator test resourcescreationTimestamp and status fields from webhook-operator test resources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR cleans up Kubernetes manifest files by removing auto-generated and runtime fields that should not be committed to source control. These fields (creationTimestamp, empty status sections, and null spec values) are typically populated by Kubernetes at runtime.
- Removed
creationTimestamp: nullfrom CRD and ClusterRole metadata - Removed empty
statussection from CustomResourceDefinition - Removed
"spec": nullentries from ClusterServiceVersion example manifests
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| webhook.operators.coreos.io_webhooktests.yaml | Removed creationTimestamp field from metadata and empty status section from CRD definition |
| webhook-operator.clusterserviceversion.yaml | Removed "spec": null entries from example resource definitions for v1 and v2 API versions |
| webhook-operator-metrics-reader_rbac.authorization.k8s.io_v1beta1_clusterrole.yaml | Removed creationTimestamp field from ClusterRole metadata |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2295 +/- ##
==========================================
+ Coverage 71.28% 74.38% +3.09%
==========================================
Files 90 90
Lines 7003 7003
==========================================
+ Hits 4992 5209 +217
+ Misses 1599 1385 -214
+ Partials 412 409 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rashmigottipati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva, rashmigottipati The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1572d1c
into
operator-framework:main
Description
Its presence has forced the BoxCutter applier to believe that resources differ from
those existing on the cluster and thus new revisions are created indefinitely on each reconcile
when trying to install webhook-operator package.
Reviewer Checklist