🐛 OCPBUGS-62942: Register cleanup-contentmanager-cache finalizer for BoxcutterRun… #2304
Conversation
…time When BoxcutterRuntime is enabled, ClusterExtensions created with the Helm runtime still have the cleanup-contentmanager-cache finalizer, but the finalizer handler is not registered in setupBoxcutter(). This causes ClusterExtension deletions to hang indefinitely. This commit registers a no-op finalizer handler in setupBoxcutter() to allow deletion of ClusterExtensions that were created before BoxcutterRuntime was enabled. Since Boxcutter doesn't use contentmanager (it has its own tracking mechanism), no actual cleanup is needed. Signed-off-by: Todd Short <tshort@redhat.com> Assisted-by: Claude code
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2304 +/- ##
==========================================
- Coverage 74.32% 74.20% -0.13%
==========================================
Files 90 90
Lines 7008 7014 +6
==========================================
- Hits 5209 5205 -4
- Misses 1392 1399 +7
- Partials 407 410 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/override codecov/patch |
|
@tmshort: Overrode contexts on behalf of tmshort: codecov/patch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 7c443eb
into
operator-framework:main
2 participants
…time
When BoxcutterRuntime is enabled, ClusterExtensions created with the Helm runtime still have the cleanup-contentmanager-cache finalizer, but the finalizer handler is not registered in setupBoxcutter(). This causes ClusterExtension deletions to hang indefinitely.
This commit registers a no-op finalizer handler in setupBoxcutter() to allow deletion of ClusterExtensions that were created before BoxcutterRuntime was enabled. Since Boxcutter doesn't use contentmanager (it has its own tracking mechanism), no actual cleanup is needed.
Assisted-by: Claude code
Description
Reviewer Checklist