✨ OPRUN-4288: Add upgrade e2es for standard to experimental #2360
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/override upgrade-e2e |
|
@tmshort: Overrode contexts on behalf of tmshort: upgrade-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
upgrade-ex2ex-e2e will continue to fail until we issue a release. |
|
When this merges, the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2360 +/- ##
=======================================
Coverage 74.45% 74.45%
=======================================
Files 93 93
Lines 7300 7300
=======================================
Hits 5435 5435
Misses 1433 1433
Partials 432 432
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
.github/workflows/e2e.yaml
Outdated
| upgrade-st2ex-e2e: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
|
|
||
| - uses: actions/setup-go@v6 | ||
| with: | ||
| go-version-file: go.mod | ||
|
|
||
| - name: Run the upgrade e2e test | ||
| run: ARTIFACT_PATH=/tmp/artifacts make test-upgrade-st2ex-e2e | ||
|
|
||
| - uses: actions/upload-artifact@v5 | ||
| if: failure() | ||
| with: | ||
| name: upgrade-st2ex-e2e-artifacts | ||
| path: /tmp/artifacts/ | ||
|
|
||
| st2ex-e2e: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
|
|
||
| - uses: actions/setup-go@v6 | ||
| with: | ||
| go-version-file: go.mod | ||
|
|
||
| - name: Run the upgrade e2e test | ||
| run: ARTIFACT_PATH=/tmp/artifacts make test-st2ex-e2e | ||
|
|
||
| - uses: actions/upload-artifact@v5 |
There was a problem hiding this comment.
Given that we are adding two more test jobs in this PR (in total now 4), would it make sense to declare a GitHub matrix job to execute them in parallel?
There was a problem hiding this comment.
They are similar enough...
There was a problem hiding this comment.
They are similar enough...
Right, hence I though we could pack them in matrix - they differ just by the makefile target it gets invoked.
There was a problem hiding this comment.
It's a bit more than that, but it's been updated to be a matrix
Signed-off-by: Todd Short <tshort@redhat.com>
|
Due to the renaming of some tests, the |
|
[nit] Given that this PR is about test infra work, and no user-facing changes, does in qualify to be marked as ✨ ? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pedjak, rashmigottipati, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/override e2e-kind |
|
@tmshort: Overrode contexts on behalf of tmshort: e2e-kind In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override upgrade-e2e |
|
@tmshort: Overrode contexts on behalf of tmshort: upgrade-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 045989d
into
operator-framework:main
3 participants
The current set of upgrade-e2e tests upgrade from the last release to the current PR/repo state. Standard is tested against standard, experimental is tested against experimental.
We should have upgrade e2e tests that upgrade from standard to experimental, including from the current PR/repo state, and also from the prior release.
This also renames the targets to make it clear what is being upgraded.
Description
Reviewer Checklist