-
Notifications
You must be signed in to change notification settings - Fork 68
🌱 Move the kind configs into a subdirectory #2384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Move the kind configs into a subdirectory #2384
Conversation
Rather than litter the root directory with kind configs, add them to a subdirectory. Also rename the experimental one to indicate it's for 2 nodes. Signed-off-by: Todd Short <tshort@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pedjak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
rashmigottipati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pedjak, rashmigottipati The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
87b2a72
into
operator-framework:main
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2384 +/- ##
==========================================
+ Coverage 70.50% 73.05% +2.55%
==========================================
Files 100 100
Lines 7641 7641
==========================================
+ Hits 5387 5582 +195
+ Misses 1847 1623 -224
- Partials 407 436 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I meant for this to be part of #2382
Rather than litter the root directory with kind configs, add them to a subdirectory.
Also rename the experimental one to indicate it's for 2 nodes.
Description
Reviewer Checklist