🐛 Discover service namespace in e2e metrics tests #2437
Conversation
Previously, the metrics test assumed the service was in a hardcoded namespace. This change queries for the service across all namespaces to find its actual location, making the test more robust against various deployment configurations.
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2437 +/- ##
==========================================
+ Coverage 69.58% 69.61% +0.02%
==========================================
Files 100 100
Lines 7641 7641
==========================================
+ Hits 5317 5319 +2
+ Misses 1889 1888 -1
+ Partials 435 434 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
camilamacedo86
left a comment
camilamacedo86
left a comment
There was a problem hiding this comment.
It seems fine for me
openshift-merge-bot
bot
merged commit fc77915
into
operator-framework:main
4 participants
Description
Previously, the metrics test assumed the service was in a hardcoded
namespace. This change queries for the service across all namespaces
to find its actual location, making the test more robust against various
deployment configurations.
Reviewer Checklist