Skip to content

🐛 Fix up single-ownnamespace e2es#2472

Merged
openshift-merge-bot[bot] merged 1 commit intooperator-framework:mainfrom
perdasilva:fix-sons-e2e
Feb 2, 2026
Merged

🐛 Fix up single-ownnamespace e2es#2472
openshift-merge-bot[bot] merged 1 commit intooperator-framework:mainfrom
perdasilva:fix-sons-e2e

Conversation

@perdasilva
Copy link
Contributor

Description

Recent condition logic changes now set Progression=False with reason InvalidConfiguration when a bad bundle configuration is supplied by the user. These changes were not reflected in the e2es. This PR fixes that up =D

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Copilot AI review requested due to automatic review settings February 2, 2026 09:07
@netlify
Copy link

netlify bot commented Feb 2, 2026

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 2e4ca34
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/698069682943a8000888d078
😎 Deploy Preview https://deploy-preview-2472--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates end-to-end test expectations to align with recent condition logic changes that now set Progressing=False with reason InvalidConfiguration (instead of Progressing=True with reason Retrying) when invalid bundle configurations are supplied.

Changes:

  • Updated two test scenarios to expect Progressing=False with Reason InvalidConfiguration for invalid watchNamespace configurations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@pedjak pedjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 2, 2026
@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.52%. Comparing base (492c7e5) to head (2e4ca34).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2472       +/-   ##
===========================================
+ Coverage   57.44%   69.52%   +12.08%     
===========================================
  Files         102      102               
  Lines        8339     8339               
===========================================
+ Hits         4790     5798     +1008     
+ Misses       3209     2078     -1131     
- Partials      340      463      +123     
Flag Coverage Δ
e2e 46.86% <ø> (?)
experimental-e2e 13.17% <ø> (?)
unit 57.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Feb 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, pedjak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [camilamacedo86,pedjak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2bdb702 into operator-framework:main Feb 2, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments