🐛 Fix up single-ownnamespace e2es#2472
🐛 Fix up single-ownnamespace e2es#2472openshift-merge-bot[bot] merged 1 commit intooperator-framework:mainfrom
Conversation
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR updates end-to-end test expectations to align with recent condition logic changes that now set Progressing=False with reason InvalidConfiguration (instead of Progressing=True with reason Retrying) when invalid bundle configurations are supplied.
Changes:
- Updated two test scenarios to expect
Progressing=False with Reason InvalidConfigurationfor invalid watchNamespace configurations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2472 +/- ##
===========================================
+ Coverage 57.44% 69.52% +12.08%
===========================================
Files 102 102
Lines 8339 8339
===========================================
+ Hits 4790 5798 +1008
+ Misses 3209 2078 -1131
- Partials 340 463 +123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, pedjak The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2bdb702
into
operator-framework:main
Description
Recent condition logic changes now set Progression=False with reason
InvalidConfigurationwhen a bad bundle configuration is supplied by the user. These changes were not reflected in the e2es. This PR fixes that up =DReviewer Checklist