✨ OPRUN-4514: Address comments on 'Move Single Own Namespace back to alpha'#2569
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Updates demo scripts and documentation to reflect the current “standard vs experimental” manifest split and clarifies when the SingleOwnNamespaceInstallSupport feature-gate is required for webhook-enabled extensions.
Changes:
- Demo cleanup now restores the standard feature set by applying
manifests/standard.yamlinstead of patching the operator-controller Deployment and applying a non-existentbase.yaml. - Tutorials clarify that webhook-enabled extensions targeting
SingleNamespace/OwnNamespacerequire theSingleOwnNamespaceInstallSupportfeature-gate. - Draft how-to note clarifies the feature is alpha and disabled by default.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| hack/demo/single-namespace-demo-script.sh | Simplifies cleanup by re-applying standard manifests to reset CRDs/deployments. |
| hack/demo/own-namespace-demo-script.sh | Same cleanup reset approach using manifests/standard.yaml. |
| docs/tutorials/explore-available-content.md | Clarifies feature-gate requirement for webhook installs targeting a single namespace. |
| docs/draft/tutorials/explore-available-content-metas-endpoint.md | Same clarification for the metas endpoint tutorial draft. |
| docs/draft/howto/single-ownnamespace-install.md | Improves wording about alpha status and default-disabled feature gate. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
docs/draft/tutorials/explore-available-content-metas-endpoint.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Todd Short <tshort@redhat.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2569 +/- ##
=======================================
Coverage 68.61% 68.61%
=======================================
Files 131 131
Lines 9333 9333
=======================================
Hits 6404 6404
Misses 2438 2438
Partials 491 491
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
55c29ef
into
operator-framework:main
Addresses comments made on #2568 (which merged wicked fast)
Description
Reviewer Checklist