🌱 Consolidate SA e2e steps and formats#2614
🌱 Consolidate SA e2e steps and formats#2614openshift-merge-bot[bot] merged 1 commit intooperator-framework:mainfrom
Conversation
Replace interpolation-style `${TEST_NAMESPACE}` references with
`test namespace` in Gherkin steps and remove the redundant step
patterns that matched the `${TEST_NAMESPACE}` syntax, consolidating
on the plain-text step definitions.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
perdasilva
changed the title
There was a problem hiding this comment.
Pull request overview
This PR standardizes the e2e Gherkin ServiceAccount step phrasing by switching from ${TEST_NAMESPACE}-style text in step lines to the literal test namespace, and simplifies the Go step registrations accordingly.
Changes:
- Updated multiple
.featurefiles to use... available in test namespacefor ServiceAccount step text. - Removed the
${TEST_NAMESPACE}-matching step regexes intest/e2e/steps/steps.go, consolidating on the plain-text step definitions.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/steps/steps.go | Removes ${TEST_NAMESPACE} ServiceAccount step patterns; keeps “test namespace” registrations. |
| test/e2e/features/user-managed-fields.feature | Updates ServiceAccount step text to “test namespace”. |
| test/e2e/features/update.feature | Updates ServiceAccount step text to “test namespace”. |
| test/e2e/features/uninstall.feature | Updates ServiceAccount step text to “test namespace”. |
| test/e2e/features/status.feature | Updates ServiceAccount step text to “test namespace”. |
| test/e2e/features/recover.feature | Updates multiple ServiceAccount step lines to “test namespace”. |
| test/e2e/features/install.feature | Updates some ServiceAccount step lines to “test namespace” (but one old form remains). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2614 +/- ##
=======================================
Coverage 68.86% 68.86%
=======================================
Files 139 139
Lines 9872 9872
=======================================
Hits 6798 6798
Misses 2557 2557
Partials 517 517
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
perdasilva
changed the title
perdasilva
changed the title
camilamacedo86
left a comment
camilamacedo86
left a comment
There was a problem hiding this comment.
I think we can move forward here.
Very small 🎉
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 10dc0bc
into
operator-framework:main
Summary
${TEST_NAMESPACE}references withtest namespacein all Gherkin feature files for ServiceAccount steps${TEST_NAMESPACE}syntax insteps.goServiceAccount steps, consolidating on the existing plain-text step definitionsTest plan
${TEST_NAMESPACE}references in feature files🤖 Generated with Claude Code