🌱 Revert "add support for --kubeconfig to operator-controller, catalogd"#2630
Conversation
This reverts commit 8ccea5a.
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
grokspawn
changed the title
There was a problem hiding this comment.
Pull request overview
Reverts the previously added explicit --kubeconfig plumbing in operator-controller and catalogd, returning both binaries to using controller-runtime’s default Kubernetes client configuration loading.
Changes:
- Removed the custom
--kubeconfigflag and associated config field from both binaries. - Removed manual kubeconfig loading via
clientcmd.BuildConfigFromFlagsand reverted toctrl.GetConfigOrDie()for REST config creation. - Cleaned up now-unused
client-go/restandclientcmdimports.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmd/operator-controller/main.go | Drops custom kubeconfig flag/loader and uses controller-runtime default config resolution. |
| cmd/catalogd/main.go | Drops custom kubeconfig flag/loader and uses controller-runtime default config resolution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2630 +/- ##
==========================================
+ Coverage 68.89% 68.99% +0.10%
==========================================
Files 139 139
Lines 9910 9891 -19
==========================================
- Hits 6827 6824 -3
+ Misses 2572 2560 -12
+ Partials 511 507 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rashmigottipati, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit fd25bf7
into
operator-framework:main
This reverts commit 8ccea5a.
Description
This PR reverts #2562. While it seemed that it was necessary, it turns out that controller-runtime already supports --kubeconfig, and to override that support we would have to invoke
RegisterFlags(which 2562 did not do).Since support was already there, and overriding that support was incomplete, we'll just revert the PR in its entirety.
Reviewer Checklist