:seedling: Ensure COS phase immutability for referenced object approach by pedjak · Pull Request #2635 · operator-framework/operator-controller

pedjak · 2026-04-08T15:28:00Z

Description

ClusterObjectSet phases are immutable by design, but when objects are stored in
external Secrets via refs, the Secret content could be changed by deleting and
recreating the Secret with the same name. This enforces phase immutability for
the referenced object approach by:

Verifying that referenced Secrets have immutable: true set
Computing a per-phase SHA-256 content digest after successful phase resolution
and recording it in .status.observedPhases
Blocking reconciliation (Progressing=False, Reason=Blocked) if any referenced
Secret is mutable or any phase's resolved content digest has changed

The digest is source-agnostic — it covers the fully resolved phase content
regardless of whether objects are inline or referenced from Secrets, making it
forward-compatible with future object sources (e.g., bundle refs).

Blocked COS resources are recoverable: they can be re-reconciled when triggered
(e.g., via annotation), re-evaluating the condition.

Reviewer Checklist

API Go Documentation
Tests: Unit Tests (and E2E Tests, if appropriate)
Comprehensive Commit Messages
Links to related GitHub Issue(s)

netlify · 2026-04-08T15:28:06Z

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	`2f24934`
🔍 Latest deploy log	https://app.netlify.com/projects/olmv1/deploys/69da50baa10a0c00099cbb52
😎 Deploy Preview	https://deploy-preview-2635--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Enforces ClusterObjectSet phase immutability when objects are sourced via referenced Secrets by requiring referenced Secrets to be immutable and by detecting Secret content changes using recorded hashes.

Changes:

Add Secret verification in the COS reconciler (immutable requirement + SHA-256 hash comparison) and block reconciliation when verification fails.
Persist referenced Secret hashes in .status.observedObjectContainers and extend CRD/applyconfigurations accordingly.
Add/extend unit + e2e coverage and update docs to reflect the new behavior.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
test/e2e/steps/steps.go	Adds new e2e steps for triggering reconciliation, message fragment matching, and checking observed Secret hashes in status.
test/e2e/features/revision.feature	Adds e2e scenarios for “mutable Secret” and “recreated Secret with changed content” blocking behavior.
manifests/experimental.yaml	Extends CRD schema with `.status.observedObjectContainers`.
manifests/experimental-e2e.yaml	Extends e2e CRD schema with `.status.observedObjectContainers`.
internal/operator-controller/controllers/resolve_ref_test.go	Updates ref-resolution tests to use immutable Secrets.
internal/operator-controller/controllers/clusterobjectset_controller_internal_test.go	Adds unit tests for Secret hashing and referenced-Secret verification.
internal/operator-controller/controllers/clusterobjectset_controller.go	Implements referenced Secret verification + hashing and blocks reconciliation on violations.
helm/olmv1/base/operator-controller/crd/experimental/olm.operatorframework.io_clusterobjectsets.yaml	Mirrors CRD schema changes for Helm packaging.
docs/draft/concepts/large-bundle-support.md	Updates documented behavior/conventions for referenced Secrets (immutability + hash enforcement).
applyconfigurations/utils.go	Registers apply-configuration kind for `ObservedObjectContainer`.
applyconfigurations/api/v1/observedobjectcontainer.go	Adds generated apply configuration for the new status type.
applyconfigurations/api/v1/clusterobjectsetstatus.go	Adds apply support for `.status.observedObjectContainers`.
api/v1/zz_generated.deepcopy.go	Adds deepcopy support for `ObservedObjectContainer` and status field.
api/v1/clusterobjectset_types.go	Introduces `ObservedObjectContainer` API type and status field.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/operator-controller/controllers/clusterobjectset_controller.go

Copilot · 2026-04-08T15:35:26Z

test/e2e/steps/steps.go

+func ClusterObjectSetReportsConditionWithMessageFragment(ctx context.Context, revisionName, conditionType, conditionStatus, conditionReason string, msgFragment *godog.DocString) error {
+	msgCmp := alwaysMatch
+	if msgFragment != nil {
+		expectedMsgFragment := substituteScenarioVars(strings.Join(strings.Fields(msgFragment.Content), " "), scenarioCtx(ctx))
+		msgCmp = func(actualMsg string) bool {
+			return strings.Contains(actualMsg, expectedMsgFragment)
+		}
+	}
+	return waitForCondition(ctx, "clusterobjectset", substituteScenarioVars(revisionName, scenarioCtx(ctx)), conditionType, conditionStatus, &conditionReason, msgCmp)
+}


This step normalizes whitespace in the expected fragment but not in the actual condition message; if the controller formats messages with newlines/multiple spaces (common when wrapping), strings.Contains may fail unexpectedly. Consider normalizing actualMsg with the same strings.Fields + Join approach before Contains to reduce e2e flakiness while still matching by fragment.

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

internal/operator-controller/controllers/clusterobjectset_controller.go:1

Treating Progressing=False, Reason=Blocked as terminal at the predicate level can prevent the controller from ever reconciling again, even if the user fixes the root cause (e.g., recreates the Secret as immutable, or changes COS spec/generation). If “Blocked” is intended to be recoverable, remove it from this predicate or gate suppression more narrowly (e.g., only suppress when generation hasn’t changed, while still allowing spec updates / explicit triggers to enqueue reconciles).

//go:build !standard

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/operator-controller/controllers/clusterobjectset_controller.go

codecov · 2026-04-08T16:34:15Z

Codecov Report

❌ Patch coverage is 71.17117% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.94%. Comparing base (dd57c28) to head (2f24934).

Files with missing lines	Patch %	Lines
api/v1/zz_generated.deepcopy.go	33.33%	8 Missing ⚠️
applyconfigurations/api/v1/observedphase.go	0.00%	8 Missing ⚠️
...troller/controllers/clusterobjectset_controller.go	90.36%	6 Missing and 2 partials ⚠️
...plyconfigurations/api/v1/clusterobjectsetstatus.go	0.00%	6 Missing ⚠️
applyconfigurations/utils.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2635      +/-   ##
==========================================
+ Coverage   68.92%   68.94%   +0.02%     
==========================================
  Files         140      141       +1     
  Lines        9905    10005     +100     
==========================================
+ Hits         6827     6898      +71     
- Misses       2566     2593      +27     
- Partials      512      514       +2

Flag	Coverage Δ
e2e	`37.41% <0.00%> (-0.41%)`	⬇️
experimental-e2e	`52.49% <65.13%> (+0.09%)`	⬆️
unit	`53.65% <60.36%> (+0.05%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

joelanford · 2026-04-08T18:40:48Z

api/v1/clusterobjectset_types.go

+	// +listType=map
+	// +listMapKey=name
+	// +optional
+	ObservedObjectContainers []ObservedObjectContainer `json:"observedObjectContainers,omitempty"`


Instead of requiring the individual objects to never change (and keeping track of per-object hashes), WDYT about computing a single hash of the resulting phases content. If that remains stable, do we care if the underlying organization of the secrets changed?

If we do that, it also means we abstract away any details of how we ultimately end up with those phases (i.e. we don't care if it is inline vs from secrets vs from a bundle ref, etc.), which would be more futureproof.

If we do that, it also means we abstract away any details of how we ultimately end up with those phases (i.e. we don't care if it is inline vs from secrets vs from a bundle ref, etc.), which would be more futureproof.

interesting idea! implemented, ptal.

joelanford · 2026-04-08T18:44:14Z

internal/operator-controller/controllers/clusterobjectset_controller.go


 func (c *ClusterObjectSetReconciler) SetupWithManager(mgr ctrl.Manager) error {
-	skipProgressDeadlineExceededPredicate := predicate.Funcs{
+	skipTerminallyBlockedPredicate := predicate.Funcs{


A terminally blocked COS could become unblocked if the user puts back the expected content though, right? We should continue reconciling to check if the expected content is back in place.

Done — removed ClusterObjectSetReasonBlocked from the skip predicate so blocked COS can be re-reconciled. If the original content is restored, the digest check passes and the COS resumes normal operation. Added an e2e recovery scenario to verify this.

camilamacedo86 · 2026-04-09T10:13:35Z

api/v1/clusterobjectset_types.go

+	// object content at first successful reconciliation.
+	//
+	// +required
+	Hash string `json:"hash"`


By creating the resolution digest we still needing this one: https://github.com/operator-framework/operator-controller/pull/2610/changes#diff-c804d15cab34d4c7c30fcd68d40d0269084c11db0736d844bd6ee8f60262a924R68

If so, could we change the name PhaseDigest?

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-09T11:18:48Z

internal/operator-controller/controllers/clusterobjectset_controller.go

+	currentPhases := make([]ocv1.ObservedPhase, 0, len(phases))
+	for _, phase := range phases {
+		hash, err := computePhaseHash(phase)
+		if err != nil {
+			setRetryingConditions(cos, err.Error())
+			return ctrl.Result{}, fmt.Errorf("computing phase hash: %v", err)
+		}
+		currentPhases = append(currentPhases, ocv1.ObservedPhase{Name: phase.GetName(), Hash: hash})
+	}


The phase hash is computed from the boxcutter phases returned by buildBoxcutterPhases(), after the reconciler mutates each resolved object (e.g., injecting labels.OwnerNameKey). This couples the stored .status.observedPhases hashes to controller-internal mutations and COS metadata, so future controller changes (or label changes) could falsely appear as “referenced content changed” and permanently block reconciliation. Consider hashing the pre-mutation resolved manifests (or normalizing/stripping controller-added fields) so the hash reflects only the referenced object content you’re trying to make immutable.

+1 to this comment. We should hash what the user provides.

Done — digest is now computed before controller mutations (label injection, collision protection). The hash reflects only the user-provided resolved content.

internal/operator-controller/controllers/clusterobjectset_controller.go

api/v1/clusterobjectset_types.go

Copilot

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-09T16:15:28Z

internal/operator-controller/controllers/clusterobjectset_controller.go

+	if len(cos.Status.ObservedPhases) == 0 {
+		cos.Status.ObservedPhases = currentPhases
+	} else if err := verifyObservedPhases(cos.Status.ObservedPhases, currentPhases); err != nil {
+		l.Error(err, "resolved phases content changed, blocking reconciliation")
+		markAsNotProgressing(cos, ocv1.ClusterObjectSetReasonBlocked, err.Error())
+		return ctrl.Result{}, nil
+	}


ObservedPhases is only populated when empty (line 172), but is never updated to include newly added phases. This breaks the immutability guarantee for phases added after initial reconciliation. When a new phase is added, it bypasses verification (line 796 checks only stored phases), and subsequent content changes to that phase won't be detected because it was never added to ObservedPhases. After verification passes, any new phases in currentPhases should be appended to cos.Status.ObservedPhases so they're tracked for future tamper detection.

Not a valid concern. The COS spec (including phases) is immutable — enforced by a CEL validation rule that prevents spec changes after creation. Phases can never be "added after initial reconciliation." The set of phases is fixed at COS creation time, so ObservedPhases will always capture all phases on the first successful resolution, and subsequent reconciliations will always have the same set of phases to verify against.

camilamacedo86

It seems fine for me 🎉
Thank you for looking on that.
/approve

openshift-ci · 2026-04-10T09:02:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

joelanford · 2026-04-10T15:10:02Z

api/v1/clusterobjectset_types.go

+	// name is the phase name matching a phase in spec.phases.
+	//
+	// +required
+	Name string `json:"name"`


Include validation markers to match spec phase name?

// +kubebuilder:validation:MinLength=1 // +kubebuilder:validation:MaxLength=63 // +kubebuilder:validation:XValidation:rule=`!format.dns1123Label().validate(self).hasValue()`,message="the value must consist of only lowercase alphanumeric characters and hyphens, and must start with an alphabetic character and end with an alphanumeric character."

Done — added MinLength, MaxLength, and DNS1123 label validation markers matching spec phase name.

joelanford · 2026-04-10T15:11:12Z

api/v1/clusterobjectset_types.go

+	// object content at first successful resolution.
+	//
+	// +required
+	Digest string `json:"digest"`


Include validation markers that reject invalid digest strings? For futureproofing, should we make the format of this string like the following?

<digestAlgoritm>:<digest>

Done — digest now uses <algorithm>:<hex> format (e.g., sha256:abcdef...). Added validation marker: self.matches('^[a-z0-9]+:[a-f0-9]+$').

joelanford · 2026-04-10T15:13:16Z

api/v1/clusterobjectset_types.go

+	// +listType=map
+	// +listMapKey=name
+	// +optional
+	ObservedPhases []ObservedPhase `json:"observedPhases,omitempty"`


Similar validations for the spec phases list?

// +kubebuilder:validation:XValidation:rule="self == oldSelf || oldSelf.size() == 0", message="observedPhases is immutable" // +kubebuilder:validation:MaxItems=20

Done — added immutability CEL rule (self == oldSelf || oldSelf.size() == 0) and MaxItems=20.

joelanford · 2026-04-10T15:19:43Z

internal/operator-controller/controllers/clusterobjectset_controller.go

+			if cnd := meta.FindStatusCondition(rev.Status.Conditions, ocv1.ClusterObjectSetTypeProgressing); cnd != nil && cnd.Status == metav1.ConditionFalse {
+				if cnd.Reason == ocv1.ReasonProgressDeadlineExceeded {
+					return false
+				}


Before and after are exactly equivalent here, right? If so, revert this change to avoid the extra conditional nesting?

Reverted — flattened back to a single condition.

joelanford · 2026-04-10T15:21:29Z

internal/operator-controller/controllers/clusterobjectset_controller.go

+func computePhaseDigest(phase boxcutter.Phase) (string, error) {
+	h := sha256.New()
+	fmt.Fprintf(h, "phase:%s\n", phase.GetName())
+	for _, obj := range phase.GetObjects() {


Double checking: phase.GetObjects() returns the list of objects in a deterministic order?

Yes — GetObjects() returns objects in the same order as specPhase.Objects, which is an immutable spec slice. The order is deterministic across reconciliations.

joelanford · 2026-04-10T15:24:29Z

internal/operator-controller/controllers/clusterobjectset_controller.go

+// produces a canonical encoding with sorted map keys.
+func computePhaseDigest(phase boxcutter.Phase) (string, error) {
+	h := sha256.New()
+	fmt.Fprintf(h, "phase:%s\n", phase.GetName())


WDYT about this:

phaseMap := map[string]any{ "name": phase.GetName(), "objects": phase.GetObjects(), } phaseData, err := json.Marshal(phaseMap) // handleErr h.Write(phaseData)

Done — switched to single json.Marshal of a map[string]any{"name": ..., "objects": ...}.

Done — adopted this approach. computePhaseDigest now marshals a map with name + objects into a single JSON blob before hashing.

joelanford · 2026-04-10T18:40:00Z

internal/operator-controller/controllers/clusterobjectset_controller.go

+		if prev, ok := storedMap[c.Name]; ok && prev != c.Digest {
+			return fmt.Errorf(
+				"resolved content of phase %q has changed (expected digest %s, got %s): "+
+					"a referenced object source may have been deleted and recreated with different content",
+				c.Name, prev, c.Digest)
+		}


Nit: collect all the diffs and report all of them?

Done — verifyObservedPhases now collects all mismatched phases and reports them in a single error message.

joelanford · 2026-04-10T18:40:36Z

internal/operator-controller/controllers/clusterobjectset_controller.go

+		if secret.Immutable == nil || !*secret.Immutable {
+			return fmt.Errorf("secret %s/%s is not immutable: referenced secrets must have immutable set to true", ref.namespace, ref.name)
+		}


Same nit: collect all mutable secrets and report all of them?

Done — verifyReferencedSecretsImmutable now collects all mutable secrets and reports them in a single error message.

joelanford · 2026-04-10T18:44:45Z

internal/operator-controller/controllers/clusterobjectset_controller_internal_test.go

+	}
+
+	t.Run("deterministic for same content", func(t *testing.T) {
+		phase := makePhase("deploy", makeObj("v1", "ConfigMap", "cm1"))


Put 100 different objects into the phase and compute the digest 100 times and make sure it's always the same?

Seems like that would cover my earlier question about deterministic ordering of the objects with a very high probability.

Also maybe a different test with the same objects but provided in a different order, which would prove that the input order matches the output order, which would cause the digest to change?

Done — added a "deterministic with many objects" test that creates 100 ConfigMaps, computes the digest 100 times, and asserts they're all identical. Also added a "different order produces different digest" test.

joelanford · 2026-04-10T18:46:53Z

internal/operator-controller/controllers/clusterobjectset_controller_internal_test.go

+	t.Run("passes when current has new phase not in stored", func(t *testing.T) {
+		stored := []ocv1.ObservedPhase{{Name: "deploy", Digest: "sha256:abc123"}}
+		current := []ocv1.ObservedPhase{
+			{Name: "deploy", Digest: "sha256:abc123"},
+			{Name: "crds", Digest: "sha256:def456"},
+		}
+		assert.NoError(t, verifyObservedPhases(stored, current))
+	})


In theory, this should never happen, right? But if it does happen shouldn't this return an error?

Done — verifyObservedPhases now returns an error when stored is empty. Also added a length check (stored != current count) to catch phase count changes.

joelanford · 2026-04-10T18:51:22Z

internal/operator-controller/controllers/clusterobjectset_controller_internal_test.go

+		require.NoError(t, err)
+	})
+
+	t.Run("deduplicates refs to same secret", func(t *testing.T) {


Nit: the test doesn't seem like it proves anything about deduplicating refs to the same secret.

Done — renamed to "checks secret only once when referenced multiple times".

joelanford · 2026-04-10T18:52:00Z

test/e2e/features/revision.feature

+    And resource "deployment/test-httpd" is installed
+    And ClusterObjectSet "${COS_NAME}" has observed phase "resources" with a non-empty digest
+
+  Scenario: ClusterObjectSet blocks reconciliation when referenced Secret is not immutable


Nit: double negative

Suggested change

Scenario: ClusterObjectSet blocks reconciliation when referenced Secret is not immutable

Scenario: ClusterObjectSet blocks reconciliation when referenced Secret is mutable

Done — scenario title is now "ClusterObjectSet blocks reconciliation when referenced Secret is mutable".

joelanford · 2026-04-10T18:53:23Z

test/e2e/features/revision.feature

+      secret ${TEST_NAMESPACE}/${COS_NAME}-mutable-secret is not immutable: referenced secrets must have immutable set to true
+    """
+
+  Scenario: ClusterObjectSet blocks reconciliation when referenced Secret content changes


This (or another) scenario that verifies that we will start reconciling again if the original content is put back and the hashes match once again?

Done — added recovery steps to the content change scenario: after the COS is blocked, we restore the original secret content, trigger reconciliation, and verify the COS resumes with Progressing=True/Succeeded.

joelanford · 2026-04-10T18:59:04Z

internal/operator-controller/controllers/clusterobjectset_controller.go

+// verifyObservedPhases compares current per-phase digests against stored
+// digests. Returns an error naming the first mismatched phase.
+func verifyObservedPhases(stored, current []ocv1.ObservedPhase) error {
+	storedMap := make(map[string]string, len(stored))


A couple of checks we should add for doing the pairwise comparison:

if len(stored) == 0 { return nil } if len(stored) != len(current) { return fmt.Errorf("number of phases has changed (expected %d phases, got %d)", len(stored), len(current)) }

Done — verifyObservedPhases now checks: (1) stored is not empty, (2) len(stored) == len(current), (3) all digests match. Tests cover all three cases.

joelanford · 2026-04-11T11:17:00Z

.bingo/gojq.mod

Something wrong with the rebase? We removed gojq in a different commit recently, right?

yeah, Claude messed things up... fixed now.

ClusterObjectSet phases are immutable by design, but when objects are stored in external Secrets via refs, the Secret content could be changed by deleting and recreating the Secret. This enforces phase immutability by: - Verifying that referenced Secrets have `immutable: true` set - Computing a per-phase SHA-256 content digest of pre-mutation resolved objects and recording it in `.status.observedPhases` - Blocking reconciliation (`Progressing=False, Reason=Blocked`) if any referenced Secret is mutable or any phase's digest has changed - Allowing blocked COS to recover when original content is restored The digest is source-agnostic — it covers fully resolved phase content regardless of whether objects are inline or from Secrets, making it forward-compatible with future object sources. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings April 8, 2026 15:28

openshift-ci bot requested review from joelanford and oceanc80 April 8, 2026 15:28

Copilot AI reviewed Apr 8, 2026

View reviewed changes

pedjak changed the title ~~✨ Ensure COS phase immutability for referenced object approach~~ 🌱 Ensure COS phase immutability for referenced object approach Apr 8, 2026

pedjak added the api-diff-lint-override label Apr 8, 2026

pedjak force-pushed the secret-verify branch from d18f093 to febe772 Compare April 8, 2026 15:42

Copilot started reviewing on behalf of pedjak April 8, 2026 15:44 View session

Copilot AI review requested due to automatic review settings April 8, 2026 15:46

pedjak force-pushed the secret-verify branch from febe772 to be47257 Compare April 8, 2026 15:46

pedjak requested review from camilamacedo86 and dtfranz and removed request for oceanc80 April 8, 2026 15:54

Copilot AI reviewed Apr 8, 2026

View reviewed changes

internal/operator-controller/controllers/clusterobjectset_controller.go Outdated Show resolved Hide resolved

internal/operator-controller/controllers/clusterobjectset_controller.go Outdated Show resolved Hide resolved

Copilot started reviewing on behalf of pedjak April 8, 2026 16:37 View session

joelanford reviewed Apr 8, 2026

View reviewed changes

pedjak force-pushed the secret-verify branch from be47257 to 19b184b Compare April 9, 2026 07:28

pedjak requested a review from joelanford April 9, 2026 07:56

camilamacedo86 reviewed Apr 9, 2026

View reviewed changes

camilamacedo86 requested a review from Copilot April 9, 2026 11:13

Copilot started reviewing on behalf of camilamacedo86 April 9, 2026 11:14 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

pedjak force-pushed the secret-verify branch from 19b184b to b95d9ab Compare April 9, 2026 15:09

Copilot AI review requested due to automatic review settings April 9, 2026 16:05

Copilot started reviewing on behalf of pedjak April 9, 2026 16:07 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

pedjak force-pushed the secret-verify branch from aee7b51 to 977477c Compare April 9, 2026 20:28

pedjak requested a review from camilamacedo86 April 9, 2026 22:25

pedjak force-pushed the secret-verify branch from 977477c to e07c75e Compare April 9, 2026 22:45

Copilot AI review requested due to automatic review settings April 9, 2026 22:45

Copilot started reviewing on behalf of pedjak April 9, 2026 22:45 View session

camilamacedo86 reviewed Apr 10, 2026

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2026

joelanford reviewed Apr 10, 2026

View reviewed changes

pedjak force-pushed the secret-verify branch from e07c75e to eb25334 Compare April 10, 2026 15:36

joelanford reviewed Apr 10, 2026

View reviewed changes

pedjak force-pushed the secret-verify branch from 567535a to 4e42707 Compare April 11, 2026 09:49

joelanford reviewed Apr 11, 2026

View reviewed changes

pedjak force-pushed the secret-verify branch from 4e42707 to e39bbe6 Compare April 11, 2026 11:53

pedjak force-pushed the secret-verify branch from e39bbe6 to 2f24934 Compare April 11, 2026 13:46

pedjak requested a review from joelanford April 11, 2026 17:25

	Scenario: ClusterObjectSet blocks reconciliation when referenced Secret is not immutable
	Scenario: ClusterObjectSet blocks reconciliation when referenced Secret is mutable

Conversation

pedjak commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Reviewer Checklist

Uh oh!

netlify bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for olmv1 ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pedjak Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Apr 10, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pedjak commented Apr 8, 2026 •

edited

Loading

netlify bot commented Apr 8, 2026 •

edited

Loading

codecov bot commented Apr 8, 2026 •

edited

Loading

pedjak Apr 9, 2026 •

edited

Loading