🐛 Fix DNS1123 validation message to match rule semantics

[pedjak]

Summary

• The XValidation message for dns1123Label() on ClusterObjectSetPhase.Name and ObservedPhase.Name incorrectly stated values "must start with an alphabetic character"
• DNS1123 labels allow starting with a digit, so the message now reads "must start and end with an alphanumeric character" to match the actual rule

Test plan

• Verify the updated validation message is accurate per RFC 1123
• Confirm generated CRD manifests reflect the corrected message

🤖 Generated with Claude Code

[netlify]

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	76ee584
🔍 Latest deploy log	https://app.netlify.com/projects/olmv1/deploys/69df9d9a7f8d3200073e522c
😎 Deploy Preview	https://deploy-preview-2652--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[Copilot]

Pull request overview

Updates the user-facing XValidation error message for dns1123Label() validations on ClusterObjectSetPhase.Name and ObservedPhase.Name so it matches DNS1123 label semantics (labels may start with a digit).

Changes:

• Adjusted kubebuilder XValidation message text in the Go API types to say “must start and end with an alphanumeric character.”
• Regenerated/updated CRD YAML outputs (manifests and Helm CRD) to carry the corrected message.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
api/v1/clusterobjectset_types.go	Updates the source-of-truth kubebuilder validation message for phase names.
manifests/experimental.yaml	Updates generated CRD manifest validation message to match the API type annotation.
manifests/experimental-e2e.yaml	Updates generated e2e CRD manifest validation message to match the API type annotation.
helm/olmv1/base/operator-controller/crd/experimental/olm.operatorframework.io_clusterobjectsets.yaml	Updates Helm-packaged CRD with the corrected validation message.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[tmshort]

/approve

[rashmigottipati]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rashmigottipati, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• api/OWNERS [tmshort]
• helm/OWNERS [tmshort]
• manifests/OWNERS [tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.89%. Comparing base (8ad71d4) to head (76ee584).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2652      +/-   ##
==========================================
- Coverage   68.91%   68.89%   -0.02%     
==========================================
  Files         141      141              
  Lines       10009    10009              
==========================================
- Hits         6898     6896       -2     
- Misses       2595     2596       +1     
- Partials      516      517       +1     

Flag	Coverage Δ
e2e	37.42% <ø> (+0.04%)	⬆️
experimental-e2e	52.49% <ø> (-0.03%)	⬇️
unit	53.62% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.