Skip to content

🌱 Remove upstream registry stubs (testdata/push and build-test-registry.sh)#2716

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
joelanford:remove-registry-stubs
May 20, 2026
Merged

🌱 Remove upstream registry stubs (testdata/push and build-test-registry.sh)#2716
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
joelanford:remove-registry-stubs

Conversation

@joelanford
Copy link
Copy Markdown
Member

@joelanford joelanford commented May 20, 2026

Remove testdata/push/ and testdata/build-test-registry.sh — stubs that were only kept for downstream CI compatibility.

Now that the downstream openshift/registry.Dockerfile has been deleted (OPRUN-4608), these are no longer needed.

Fixes: https://issues.redhat.com/browse/OPRUN-4609

Copilot AI review requested due to automatic review settings May 20, 2026 03:04
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 20, 2026 •
edited
Loading

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 0db158a
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6a0d48028b557e0008f7c9e3
😎 Deploy Preview https://deploy-preview-2716--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI reviewed May 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR is intended to remove upstream registry stubs (testdata/push/ and testdata/build-test-registry.sh) that were kept for downstream CI compatibility, but the current diff only adds a placeholder file and does not include the described removals.

Changes:

  • Adds a placeholder file .oprun-4609 (no functional changes related to registry stubs are present in the provided diff).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .oprun-4609 Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.12%. Comparing base (3977e09) to head (0db158a).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2716      +/-   ##
==========================================
- Coverage   68.14%   68.12%   -0.02%     
==========================================
  Files         145      145              
  Lines       10698    10698              
==========================================
- Hits         7290     7288       -2     
- Misses       2879     2880       +1     
- Partials      529      530       +1
Flag Coverage Δ
e2e 37.17% <ø> (+0.02%) ⬆️
experimental-e2e 52.71% <ø> (+0.02%) ⬆️
unit 53.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joelanford joelanford force-pushed the remove-registry-stubs branch from 1507d5f to dd8dafe Compare May 20, 2026 05:30
@joelanford
chore: remove upstream registry stubs
0db158a 
Delete testdata/push/ and testdata/build-test-registry.sh, which were
no-op stubs kept only for backward compatibility with downstream CI.
That dependency has been removed, so these files are no longer needed.
Copilot AI review requested due to automatic review settings May 20, 2026 05:34
@joelanford joelanford force-pushed the remove-registry-stubs branch from dd8dafe to 0db158a Compare May 20, 2026 05:34
Copilot AI reviewed May 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@joelanford joelanford changed the title Remove upstream registry stubs (testdata/push and build-test-registry.sh) 🌱 Remove upstream registry stubs (testdata/push and build-test-registry.sh) May 20, 2026
@joelanford joelanford marked this pull request as ready for review May 20, 2026 05:37
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2026
@openshift-ci openshift-ci Bot requested review from ankitathomas and trgeiger May 20, 2026 05:37
@dtfranz
Copy link
Copy Markdown
Contributor

dtfranz commented May 20, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2026
pedjak
pedjak approved these changes May 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@pedjak pedjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtfranz, pedjak, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit bec2028 into operator-framework:main May 20, 2026
29 of 30 checks passed
@joelanford joelanford deleted the remove-registry-stubs branch May 20, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@pedjak pedjak pedjak approved these changes

@rashmigottipati rashmigottipati rashmigottipati approved these changes

@dtfranz dtfranz dtfranz approved these changes

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@trgeiger trgeiger Awaiting requested review from trgeiger

Assignees

@pedjak pedjak

@rashmigottipati rashmigottipati

@dtfranz dtfranz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joelanford @dtfranz @pedjak @rashmigottipati