🌱 fix: align OTel versions to v1.44.0 and use explicit e2e timeout fallback#2791
🌱 fix: align OTel versions to v1.44.0 and use explicit e2e timeout fallback#2791tmshort wants to merge 1 commit into
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR updates dependency versions to keep OpenTelemetry (OTel) components consistent and adjusts the Makefile’s e2e test invocation so the default go test -timeout fallback is explicit at the call site (while still allowing variant-specific overrides).
Changes:
- Bump selected OTel Go module dependencies to
v1.44.0to match other OTel modules already atv1.44.0. - Update the
e2e-run-%recipe to use an explicit-timeout $(or $(E2E_TIMEOUT),20m)fallback, making default/override behavior unambiguous. - Refresh related indirect dependency versions and checksums (
grpc-gateway,genproto, etc.) as part of module resolution.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Makefile | Makes the e2e go test -timeout default explicit via $(or $(E2E_TIMEOUT),20m) while preserving overrides (e.g., experimental uses 25m). |
| go.mod | Updates indirect dependency versions, including OTel trace exporter + SDK to v1.44.0. |
| go.sum | Updates corresponding module checksums and records the resolved dependency graph. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| go.opentelemetry.io/otel v1.44.0 // indirect | ||
| go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.43.0 // indirect | ||
| go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.43.0 // indirect | ||
| go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.44.0 // indirect | ||
| go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.44.0 // indirect | ||
| go.opentelemetry.io/otel/metric v1.44.0 // indirect | ||
| go.opentelemetry.io/otel/sdk v1.43.0 // indirect | ||
| go.opentelemetry.io/otel/sdk v1.44.0 // indirect |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2791 +/- ##
==========================================
- Coverage 70.44% 70.29% -0.16%
==========================================
Files 143 142 -1
Lines 10625 10577 -48
==========================================
- Hits 7485 7435 -50
- Misses 2579 2580 +1
- Partials 561 562 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/lgtm |
…back - Upgrade go.opentelemetry.io/otel/exporters/otlp/otlptrace, otlptracegrpc, and otel/sdk from v1.43.0 to v1.44.0 to match otel, otel/metric, and otel/trace already at v1.44.0 - Move E2E_TIMEOUT fallback from target-specific ?= into the e2e-run-% recipe via $(or $(E2E_TIMEOUT),20m) so the 20m default is explicit and the 25m override from test-experimental-e2e is unambiguous Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Todd Short <tshort@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rashmigottipati The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Discovered when code was being downstreamed.
Description
Reviewer Checklist