fix(csv): CSV update process optimization regression#407
Merged
ecordell merged 9 commits intooperator-framework:masterfrom Aug 7, 2018
Merged
fix(csv): CSV update process optimization regression#407ecordell merged 9 commits intooperator-framework:masterfrom
ecordell merged 9 commits intooperator-framework:masterfrom
Conversation
the optimization that marks multiple CSVs for deleting during one loop is broken
updated more frequently
njhale
reviewed
Aug 5, 2018
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| // configure cluster state | ||
| clientFake := fake.NewSimpleClientset(tt.initial.csvs...) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recommend reviewing by commit.
This was an adventure:
Before merging I want to play with this on a real cluster, but everything looks good locally.
Also: