OPRUN-4628: restrict dynamic version selection for default catalogsources to only apply to v5.0->v4.y

[ankitathomas]

The sentinel value approach in #750 risks breaking CI on branch cut for 5.1 based on the availability of the 5.1 catalogs. This PR restricts the catalog tag override to only apply to v5.0 catalogs, and only if the OCP version provided through the RELEASE_VERSION env variable is a 4.y semver version.

Description of the change:

Motivation for the change:

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /docs
• Commit messages sensible and descriptive

[openshift-ci-robot]

@ankitathomas: This pull request references OPRUN-4628 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

The sentinel value approach in #750 risks breaking CI on branch cut for 5.1 based on the availability of the 5.1 catalogs. This PR restricts the catalog tag override to only apply to v5.0 catalogs, and only if the OCP version provided through the RELEASE_VERSION env variable is a 4.y semver version.

Description of the change:

Motivation for the change:

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /docs
• Commit messages sensible and descriptive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tmshort]

This should be the OLMv0 version of OLMv1's openshift/cluster-olm-operator#210

[rashmigottipati]

/retest-required

[ankitathomas]

/retest

[ankitathomas]

/retest

[tmshort]

/approve

[rashmigottipati]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rashmigottipati, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[perdasilva]

/verified by @perdasilva

[openshift-ci-robot]

@perdasilva: This PR has been marked as verified by @perdasilva.

Details

In response to this:

/verified by @perdasilva

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.