Skip to content

Conversation

@joelanford
Copy link
Member

Signed-off-by: Joe Lanford joe.lanford@gmail.com

Description of the change:
Update opm render help text:

  1. Use file-based catalog terminology instead of "declarative configs"
  2. Include the fact that the output is a stream of objects to stdout, not a single object.

Motivation for the change:
General documentation maintenance and to help clarify the format of data that is produced (its a stream of documents, not one document).

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

…dout

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@openshift-ci openshift-ci bot requested review from jmrodri and njhale January 17, 2023 21:38
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2023
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #1056 (499f318) into master (0080ea0) will increase coverage by 0.05%.
The diff coverage is 70.37%.

@@            Coverage Diff             @@
##           master    #1056      +/-   ##
==========================================
+ Coverage   52.06%   52.12%   +0.05%     
==========================================
  Files         102      102              
  Lines        9218     9244      +26     
==========================================
+ Hits         4799     4818      +19     
- Misses       3505     3512       +7     
  Partials      914      914              
Impacted Files Coverage Δ
alpha/declcfg/load.go 76.52% <70.37%> (-2.13%) ⬇️
alpha/veneer/semver/semver.go 65.02% <0.00%> (+0.49%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@anik120 anik120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120, everettraven, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3bfcb23 into operator-framework:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants