adding olm.bundle image/relatedImages pullspec format validation#1905
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1905 +/- ##
==========================================
+ Coverage 57.44% 57.47% +0.03%
==========================================
Files 139 139
Lines 13323 13334 +11
==========================================
+ Hits 7653 7664 +11
Misses 4488 4488
Partials 1182 1182 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
grokspawn
force-pushed
the
validate-bundle-image-pullspecs
branch
3 times, most recently
from
5b788c0 to
3bb33ee
Compare
Signed-off-by: grokspawn <jordan@nimblewidget.com> Assisted-By: Claude
grokspawn
force-pushed
the
validate-bundle-image-pullspecs
branch
from
3bb33ee to
114eeb7
Compare
| Bundles: []Bundle{newTestBundle("foo", "0.1.0", func(b *Bundle) { | ||
| b.RelatedImages = []RelatedImage{ | ||
| {Name: "bundle", Image: testBundleImage("foo", "0.1.0")}, | ||
| {Name: "operator", Image: "quay.io/operator-framework/my-operator@ssha256:abcd1234abcd1234abcd1234abcd1234abcd1234abcd1234abcd1234abcd1234"}, |
There was a problem hiding this comment.
I feel like the same kind of invalid pull spec is being used here and in line 517. But here it's an invalid pull spec, and for the test case in 517 its an unsupported digest. Is there a difference between these two cases that we care about?
|
/approve just a small nit - let me know if you want to address it and I'll re-approve |
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 81aee76
into
operator-framework:master
5 participants
Assisted-By: Claude
Description of the change:
Motivation for the change:
Reviewer Checklist
/docs