OCPBUGS-76487: substitutes template protects against reuse of base/candidate

[grokspawn]

Description of the change:
track bases and candidates to prevent reuse as both can introduce skips edges which make graphs nondeterministic.

Motivation for the change:

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /docs
• Commit messages sensible and descriptive

[openshift-ci-robot]

@grokspawn: This pull request references Jira Issue OCPBUGS-76487, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Description of the change:
track bases and candidates to prevent reuse as both can introduce skips edges which make graphs nondeterministic.

Motivation for the change:

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /docs
• Commit messages sensible and descriptive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.70%. Comparing base (21f9b55) to head (09d9d51).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1942      +/-   ##
==========================================
+ Coverage   57.68%   57.70%   +0.02%     
==========================================
  Files         139      139              
  Lines       13363    13371       +8     
==========================================
+ Hits         7708     7716       +8     
  Misses       4468     4468              
  Partials     1187     1187              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tmshort]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[grokspawn]

fixing gci format sanity, as well as

/jira refresh

[openshift-ci-robot]

@grokspawn: This pull request references Jira Issue OCPBUGS-76487, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

fixing gci format sanity, as well as

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[grokspawn]

/jira refresh

[openshift-ci-robot]

@grokspawn: This pull request references Jira Issue OCPBUGS-76487, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Xia-Zhao-rh

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[Xia-Zhao-rh]

/lgtm

[openshift-ci-robot]

@grokspawn: Jira Issue OCPBUGS-76487: All pull requests linked via external trackers have merged:

• operator-framework/operator-registry#1942

Jira Issue OCPBUGS-76487 has been moved to the MODIFIED state.

Details

In response to this:

Description of the change:
track bases and candidates to prevent reuse as both can introduce skips edges which make graphs nondeterministic.

Motivation for the change:

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /docs
• Commit messages sensible and descriptive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rashmigottipati]

/lgtm