Skip to content

prune unused dockerfiles & build targets#1961

Merged
openshift-merge-bot[bot] merged 1 commit intooperator-framework:masterfrom
grokspawn:prune-old-dockerfiles
Apr 21, 2026
Merged

prune unused dockerfiles & build targets#1961
openshift-merge-bot[bot] merged 1 commit intooperator-framework:masterfrom
grokspawn:prune-old-dockerfiles

Conversation

@grokspawn
Copy link
Copy Markdown
Contributor

Description of the change:
Removes a couple of dockerfiles which aren't currently used in build/release processes. We can resurrect them in future if we need to.
Removes a build target which refers to a dockerfile which isn't even present in the repo.

Motivation for the change:
Replaces #1914

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Signed-off-by: grokspawn <jordan@nimblewidget.com>
Copilot AI review requested due to automatic review settings April 17, 2026 19:33
@openshift-ci openshift-ci Bot requested review from joelanford and tmshort April 17, 2026 19:34
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up container build artifacts by removing Dockerfiles and a Makefile build target that are not used by the current build/release workflows, reducing maintenance surface and confusion around supported image builds.

Changes:

  • Delete upstream-opm-builder.Dockerfile (deprecated builder Dockerfile).
  • Delete registry.Dockerfile (standalone registry-server image Dockerfile).
  • Remove the image-upstream Makefile target that builds upstream-example.Dockerfile.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
upstream-opm-builder.Dockerfile Removed unused/deprecated Dockerfile.
registry.Dockerfile Removed standalone registry-server Dockerfile.
Makefile Removed unused image-upstream build target.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Makefile
Comment thread Makefile
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.71%. Comparing base (12f8cdd) to head (18ff135).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1961   +/-   ##
=======================================
  Coverage   57.71%   57.71%           
=======================================
  Files         139      139           
  Lines       13373    13373           
=======================================
  Hits         7718     7718           
  Misses       4468     4468           
  Partials     1187     1187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented Apr 21, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2026
@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented Apr 21, 2026

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 3855305 into operator-framework:master Apr 21, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants