prune unused dockerfiles & build targets#1961
prune unused dockerfiles & build targets#1961openshift-merge-bot[bot] merged 1 commit intooperator-framework:masterfrom
Conversation
Signed-off-by: grokspawn <jordan@nimblewidget.com>
There was a problem hiding this comment.
Pull request overview
This PR cleans up container build artifacts by removing Dockerfiles and a Makefile build target that are not used by the current build/release workflows, reducing maintenance surface and confusion around supported image builds.
Changes:
- Delete
upstream-opm-builder.Dockerfile(deprecated builder Dockerfile). - Delete
registry.Dockerfile(standaloneregistry-serverimage Dockerfile). - Remove the
image-upstreamMakefile target that buildsupstream-example.Dockerfile.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| upstream-opm-builder.Dockerfile | Removed unused/deprecated Dockerfile. |
| registry.Dockerfile | Removed standalone registry-server Dockerfile. |
| Makefile | Removed unused image-upstream build target. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1961 +/- ##
=======================================
Coverage 57.71% 57.71%
=======================================
Files 139 139
Lines 13373 13373
=======================================
Hits 7718 7718
Misses 4468 4468
Partials 1187 1187 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3855305
into
operator-framework:master
Description of the change:
Removes a couple of dockerfiles which aren't currently used in build/release processes. We can resurrect them in future if we need to.
Removes a build target which refers to a dockerfile which isn't even present in the repo.
Motivation for the change:
Replaces #1914
Reviewer Checklist
/docs