OCPBUGS-85775: validate skipRange with blang/semver ParseRange

[joelanford]

Description of the change:

opm validate does not validate the skipRange field in operator bundle metadata. Invalid semver ranges (e.g. >v0.1.0, >1.00.1) are silently accepted, which can lead to broken upgrade graphs discovered only at runtime.

This PR adds validation of the skipRange field in Bundle.Validate() using semver.ParseRange() from the blang/semver library (already a dependency). Any parse error is surfaced in the validation error tree.

Motivation for the change:

Invalid skipRange values should be caught at build/validation time rather than at install time. This makes opm validate more reliable as a pre-publish check.

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /docs
• Commit messages sensible and descriptive

Jira: https://redhat.atlassian.net/browse/OCPBUGS-85775

🤖 Generated with Claude Code via /jira:solve OCPBUGS-85775

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign pedjak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@joelanford: This pull request references Jira Issue OCPBUGS-85775, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Description of the change:

opm validate does not validate the skipRange field in operator bundle metadata. Invalid semver ranges (e.g. >v0.1.0, >1.00.1) are silently accepted, which can lead to broken upgrade graphs discovered only at runtime.

This PR adds validation of the skipRange field in Bundle.Validate() using semver.ParseRange() from the blang/semver library (already a dependency). Any parse error is surfaced in the validation error tree.

Motivation for the change:

Invalid skipRange values should be caught at build/validation time rather than at install time. This makes opm validate more reliable as a pre-publish check.

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /docs
• Commit messages sensible and descriptive

Jira: https://redhat.atlassian.net/browse/OCPBUGS-85775

🤖 Generated with Claude Code via /jira:solve OCPBUGS-85775

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[Copilot]

Pull request overview

This PR adds skipRange syntax validation to bundle model validation so invalid semver ranges are caught by opm validate before publication/runtime graph use.

Changes:

• Validates non-empty Bundle.SkipRange using blang/semver’s ParseRange.
• Adds unit tests covering a valid range and invalid ranges with a leading v and leading zeroes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
alpha/model/model.go	Adds skipRange parse validation to Bundle.Validate().
alpha/model/model_test.go	Adds validator test cases for valid and invalid skipRange values.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.88%. Comparing base (fdecf0e) to head (8ac96c2).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1987      +/-   ##
==========================================
+ Coverage   57.71%   57.88%   +0.17%     
==========================================
  Files         139      140       +1     
  Lines       13373    13451      +78     
==========================================
+ Hits         7718     7786      +68     
- Misses       4468     4474       +6     
- Partials     1187     1191       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.