-
Notifications
You must be signed in to change notification settings - Fork 261
Prune operator version #718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prune operator version #718
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: monkey1016 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @monkey1016. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Khaled Janania <kjanania@redhat.com>
Signed-off-by: Khaled Janania <kjanania@redhat.com>
Signed-off-by: Joe Lanford <joe.lanford@gmail.com> Signed-off-by: Khaled Janania <kjanania@redhat.com>
Signed-off-by: Joe Lanford <joe.lanford@gmail.com> Signed-off-by: Khaled Janania <kjanania@redhat.com>
Signed-off-by: Joe Lanford <joe.lanford@gmail.com> Signed-off-by: Khaled Janania <kjanania@redhat.com>
Signed-off-by: Joe Lanford <joe.lanford@gmail.com> Signed-off-by: Khaled Janania <kjanania@redhat.com>
Signed-off-by: Joe Lanford <joe.lanford@gmail.com> Signed-off-by: Khaled Janania <kjanania@redhat.com>
Implements enhancements/catalog-data-transfer-reduction.md Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com> Signed-off-by: Khaled Janania <kjanania@redhat.com>
8c7903e to
c65b4cf
Compare
…or-registry into prune-operator-version
7b2484d to
8c8c609
Compare
removing unused code and commented code Signed-off-by: Khaled Janania <kjanania@redhat.com>
Signed-off-by: Khaled Janania <kjanania@redhat.com>
8c8c609 to
ed81392
Compare
|
@monkey1016 have you seen #696 and #716? The latter effectively implements the functionality you want in this PR, with channel support as well; does it cover your goals? |
|
@estroz I have not. I'll take a look at them and cancel this pull request. Thanks! |
Description of the change:
Introduces a new command,
prune-versionwhich allows the catalog to be pruned similar to the originalprunecommand , but instead keeps specific versions of operators instead of all versions for a given operator. It was added as a hidden command since it is a command that could cause instability if done incorrectly, for example breaking upgrade paths if a specific version required in the upgrade path is not added to the list.Motivation for the change:
We've run into situations many times where we don't need every version of a given operator, only the latest or the second latest (or maybe even slightly older) operator on a given day due to how approvals for application versions work for the organization. The current
prunecommand pulls in every version of the operator which causes us to mirror a large number of images we don't care about. Just three operators would mirror more than 3500 images, even though we only care about one or two versions for each operator.Reviewer Checklist
/docs