Skip to content

Conversation

@monkey1016
Copy link

Description of the change:
Introduces a new command, prune-version which allows the catalog to be pruned similar to the original prune command , but instead keeps specific versions of operators instead of all versions for a given operator. It was added as a hidden command since it is a command that could cause instability if done incorrectly, for example breaking upgrade paths if a specific version required in the upgrade path is not added to the list.

Motivation for the change:
We've run into situations many times where we don't need every version of a given operator, only the latest or the second latest (or maybe even slightly older) operator on a given day due to how approvals for application versions work for the organization. The current prune command pulls in every version of the operator which causes us to mirror a large number of images we don't care about. Just three operators would mirror more than 3500 images, even though we only care about one or two versions for each operator.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: monkey1016
To complete the pull request process, please assign dinhxuanvu after the PR has been reviewed.
You can assign the PR to them by writing /assign @dinhxuanvu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from ecordell and njhale July 27, 2021 13:37
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 27, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2021

Hi @monkey1016. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

monkey1016 and others added 8 commits July 27, 2021 09:39
Signed-off-by: Khaled Janania <kjanania@redhat.com>
Signed-off-by: Khaled Janania <kjanania@redhat.com>
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Signed-off-by: Khaled Janania <kjanania@redhat.com>
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Signed-off-by: Khaled Janania <kjanania@redhat.com>
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Signed-off-by: Khaled Janania <kjanania@redhat.com>
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Signed-off-by: Khaled Janania <kjanania@redhat.com>
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Signed-off-by: Khaled Janania <kjanania@redhat.com>
Implements enhancements/catalog-data-transfer-reduction.md

Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
Signed-off-by: Khaled Janania <kjanania@redhat.com>
@monkey1016 monkey1016 force-pushed the prune-operator-version branch from 8c7903e to c65b4cf Compare July 27, 2021 13:39
@monkey1016 monkey1016 force-pushed the prune-operator-version branch 2 times, most recently from 7b2484d to 8c8c609 Compare July 27, 2021 18:45
removing unused code and commented code

Signed-off-by: Khaled Janania <kjanania@redhat.com>
Signed-off-by: Khaled Janania <kjanania@redhat.com>
@monkey1016 monkey1016 force-pushed the prune-operator-version branch from 8c8c609 to ed81392 Compare July 27, 2021 18:50
@estroz
Copy link
Member

estroz commented Jul 28, 2021

@monkey1016 have you seen #696 and #716? The latter effectively implements the functionality you want in this PR, with channel support as well; does it cover your goals?

@monkey1016
Copy link
Author

@estroz I have not. I'll take a look at them and cancel this pull request. Thanks!

@monkey1016 monkey1016 closed this Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants