feat(opm diff): include packages, channels, and versions in diff output

[estroz]

Description of the change: use --include-file,-i to include a set of packages, channels, and/or versions in opm alpha diff output.

Motivation for the change: you may want to explicitly include an upgrade graph (especially in heads-only mode) in your diff, ex. when you have a specific version requirement.

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /docs
• Commit messages sensible and descriptive

TODO:

• tests
• code comments

/kind feature

[codecov]

Codecov Report

Merging #716 (9048884) into master (a3253eb) will decrease coverage by 0.26%.
The diff coverage is 29.59%.

❗ Current head 9048884 differs from pull request most recent head 836c742. Consider uploading reports for the commit 836c742 to get more accurate results

@@            Coverage Diff             @@
##           master     #716      +/-   ##
==========================================
- Coverage   50.90%   50.64%   -0.27%     
==========================================
  Files         102      102              
  Lines        8753     8846      +93     
==========================================
+ Hits         4456     4480      +24     
- Misses       3458     3522      +64     
- Partials      839      844       +5     

Impacted Files	Coverage Δ
alpha/declcfg/diff_include.go	31.91% <3.17%> (-58.72%)	⬇️
alpha/declcfg/diff.go	77.14% <45.45%> (-2.17%)	⬇️
alpha/action/diff.go	75.86% <91.66%> (+11.15%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3253eb...836c742. Read the comment docs.

[estroz]

I still need to add more tests, but this is ready for review.

/cc @joelanford @kevinrizza

[ankitathomas]

Great work! This needs some refactoring over the olm.channel schema added.

[ankitathomas]

This looks like it's missing a render step for including the old catalog in the declarative config directory.

[estroz]

Done. the old catalog shouldn't be in the DC dir, just the diff in my-catalog-index/index.yaml.

[estroz]

/override go-apidiff / go-apidiff

[openshift-ci]

@estroz: /override requires a failed status context or a job name to operate on.
The following unknown contexts were given:

• go-apidiff / go-apidiff

Only the following contexts were expected:

• DCO
• build
• e2e
• sanity
• tide
• unit

In response to this:

/override go-apidiff / go-apidiff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[estroz]

@joelanford we should probably ignore the alpha package when running apidiff.

[joelanford]

That would be a new feature for apidiff. Right now it considers anything that is technically possible to be imported by another project as a public API.

[estroz]

Ah bummer. Since the test is not required, prow should merge this when lgtm'd anyway.

[kevinrizza]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: estroz, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kevinrizza]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[joelanford]

/lgtm