Skip to content

Conversation

@joelanford
Copy link
Member

Signed-off-by: Joe Lanford joe.lanford@gmail.com

Description of the change:
When rendering bundles, make sure to parse the CSV's deployment specs to extract any images that aren't otherwise explicitly included in the CSV's related images field.

Motivation for the change:

When used to mirror a catalog to a disconnected environment, we should take care to try to find all of the related images that we can, even if they aren't explicitly included as related images by the operator author.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

…images

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2021
@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #771 (ce9afbc) into master (0a190a8) will increase coverage by 0.03%.
The diff coverage is 87.50%.

❗ Current head ce9afbc differs from pull request most recent head babafb6. Consider uploading reports for the commit babafb6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #771      +/-   ##
==========================================
+ Coverage   50.41%   50.45%   +0.03%     
==========================================
  Files         102      102              
  Lines        8725     8719       -6     
==========================================
  Hits         4399     4399              
+ Misses       3473     3470       -3     
+ Partials      853      850       -3     
Impacted Files Coverage Δ
pkg/sqlite/query.go 64.61% <86.66%> (-0.02%) ⬇️
alpha/action/render.go 64.02% <88.23%> (+2.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a190a8...babafb6. Read the comment docs.


// Keep track of the images we've already found, so that we don't add
// them multiple times.
allImages := sets.NewString()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

til about "k8s.io/apimachinery/pkg/util/sets"

@kevinrizza
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2021
@openshift-merge-robot openshift-merge-robot merged commit f5dcf40 into operator-framework:master Sep 1, 2021
@joelanford joelanford deleted the fbc-related-bundle-image branch September 1, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants