render: populate related images even when CSV has none explicitly defined #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
…ined Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
joelanford
force-pushed
the
fix/render-bundle-related-images2
branch
from
d939210 to
9f9a39b
Compare
Codecov Report
@@ Coverage Diff @@
## master #797 +/- ##
==========================================
+ Coverage 51.18% 51.20% +0.01%
==========================================
Files 103 103
Lines 9078 9077 -1
==========================================
+ Hits 4647 4648 +1
+ Misses 3551 3550 -1
+ Partials 880 879 -1
Continue to review full report at Codecov.
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
akihikokuroda
pushed a commit
to akihikokuroda/operator-registry
that referenced
this pull request
Sep 30, 2021
…ined (operator-framework#797) Signed-off-by: Joe Lanford <joe.lanford@gmail.com> Signed-off-by: akihikokuroda <akihikokuroda2020@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
When
opm renderrenders a bundle, it currently produces zero related images if the CSV does not have an explicitspec.relatedImagesfield.This is update to fix an edge case not already fixed in #771.
Motivation for the change:
Related images can be derived from a CSV even when the CSV does not explicitly contain a
spec.relatedImagesfield.Reviewer Checklist
/docs