Skip to content

Conversation

@estroz
Copy link
Member

@estroz estroz commented Sep 22, 2021

Description of the change: include bundle names instead of versions in include config

Motivation for the change: see #716 (comment)

/kind feature

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
@openshift-ci openshift-ci bot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 22, 2021
@estroz
Copy link
Member Author

estroz commented Sep 22, 2021

/cc @kevinrizza

@openshift-ci openshift-ci bot requested a review from kevinrizza September 22, 2021 21:11
@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #787 (fd2e3fc) into master (9c330a2) will decrease coverage by 0.02%.
The diff coverage is 38.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #787      +/-   ##
==========================================
- Coverage   50.65%   50.62%   -0.03%     
==========================================
  Files         102      102              
  Lines        8879     8896      +17     
==========================================
+ Hits         4498     4504       +6     
- Misses       3530     3541      +11     
  Partials      851      851              
Impacted Files Coverage Δ
alpha/declcfg/diff_include.go 28.30% <0.00%> (-3.62%) ⬇️
alpha/action/diff.go 76.66% <100.00%> (+0.80%) ⬆️
alpha/declcfg/diff.go 77.46% <100.00%> (+0.32%) ⬆️
pkg/registry/query.go 60.93% <0.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c330a2...fd2e3fc. Read the comment docs.

@kevinrizza
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: estroz, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2021
@ankitathomas
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2021
@openshift-merge-robot openshift-merge-robot merged commit 8d805a2 into operator-framework:master Sep 23, 2021
@estroz estroz deleted the feat/diff-include-bundle-names branch September 23, 2021 15:51
akihikokuroda pushed a commit to akihikokuroda/operator-registry that referenced this pull request Sep 30, 2021
Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
Signed-off-by: akihikokuroda <akihikokuroda2020@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants