-
Notifications
You must be signed in to change notification settings - Fork 260
feat: copy only index file from container filesystem #800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
entire filesystem via a tar stream. Signed-off-by: Daniel Sover <dsover@redhat.com>
Signed-off-by: Daniel Sover <dsover@redhat.com>
- simplify concurrent docker|podman cp + untar logic - rename exporter -> untarer to match use - rename exporter.Export to exporter.Untar - make exporter.Untar more "pure" by adding parameters for the path and tar reader Signed-off-by: Nick Hale <njohnhale@gmail.com>
Signed-off-by: Daniel Sover <dsover@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: exdx The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #800 +/- ##
==========================================
- Coverage 50.90% 49.77% -1.14%
==========================================
Files 102 108 +6
Lines 8753 9342 +589
==========================================
+ Hits 4456 4650 +194
- Misses 3458 3807 +349
- Partials 839 885 +46
Continue to review full report at Codecov.
|
|
Seeing a new interesting failure |
Signed-off-by: Daniel Sover <dsover@redhat.com>
|
@exdx: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of the change:
Builds off #775
Pruning an index via opm index prune can fail when permissions on the filesystem in the container are read-only. Since the command copies all files out from the container it is prone to failure. Fora example, the red hat operators catalog is based on the UBI image, which contains some directories with elevated permissions (/root/* for example). Extract the entire contents of this container filesystem via docker cp will fail. This PR copies out the content of the file by copying the container contents to stdout as a tar stream and then writing the untarred content to disk.
Motivation for the change:
Reviewer Checklist
/docs