Skip to content

Using GoReleaser to manage GitHub releases #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Using GoReleaser to manage GitHub releases #913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 0 additions & 48 deletions .github/workflows/release.yaml
View file
Open in desktop

This file was deleted.

33 changes: 30 additions & 3 deletions .goreleaser.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,34 @@ builds:
asmflags: *build-asmflags
gcflags: *build-gcflags
ldflags: *build-ldflags
- id: darwin-amd64
Copy link
Member

@joelanford joelanford Feb 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't build macos binaries via goreleaser because the macos compiler is not available (and not licensed for use) on Linux.

So the macos binary builds need to continue to be run on macos-latest machines via the github action. And then rather than using goreleaser's github release integration, we'll have to tie all this together via github actions to create the release and upload the assets, similar to what we're doing in .github/workflows/release.yaml

main: ./cmd/opm
binary: opm
goos:
- darwin
goarch:
- amd64
env:
- CC=o64-clang
mod_timestamp: "{{ .CommitTimestamp }}"
flags: *build-flags
asmflags: *build-asmflags
gcflags: *build-gcflags
ldflags: *build-ldflags
- id: darwin-arm64
main: ./cmd/opm
binary: opm
goos:
- darwin
goarch:
- arm64
env:
- CC=oa64e-clang
mod_timestamp: "{{ .CommitTimestamp }}"
flags: *build-flags
asmflags: *build-asmflags
gcflags: *build-gcflags
ldflags: *build-ldflags
archives:
- id: opm
builds:
Expand All @@ -90,6 +118,8 @@ archives:
- linux-ppc64le
- linux-s390x
- windows-amd64
- darwin-amd64
- darwin-arm64
name_template: "{{ .Binary }}_{{ .Env.OPM_VERSION }}_{{ .Os }}_{{ .Arch }}"
format: binary
dockers:
Expand Down Expand Up @@ -169,6 +199,3 @@ snapshot:
release:
name_template: "{{ .Env.OPM_VERSION }}"
draft: true
## Disable release steps, since a separate GitHub Action job
## handles binary builds and release uploads
disable: true
2 changes: 1 addition & 1 deletion docs/contributors/releases.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## opm

Binary releases of opm are built by Github Actions, see [release.yaml](../../.github/workflows/release.yaml) for details.
Binary releases of opm are built by Github Actions, see [goreleaser.yaml](../../.github/workflows/goreleaser.yaml) for details.
amd64 builds are produced for linux, macos, and windows.

opm follows semantic versioning, with the latest version derived from the newest semver tag.
Expand Down
3 changes: 1 addition & 2 deletions release/goreleaser.opm.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# NOTE: This Dockerfile is used in conjuction with GoReleaser to
# build opm images. See the configurations in .goreleaser.yaml
# and .github/workflows/release.yaml.
# build opm images. See the configurations in .goreleaser.yaml.

FROM alpine as grpc_health_probe
ARG TARGETARCH
Expand Down