Skip to content

Conversation

@aemperador
Copy link

Description of the change:
Change to use GoReleaser to manage GitHub releases. Originally just wanted to publish ppc64le Github binaries.
@joelanford Please let me know the best way to test this. I ran it locally to ensure minimal errors, but was not able to cover all architectures.

Motivation for the change:
First attempt to add ppc64le binaries to GitHub releases - #631

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 1, 2022

Hi @aemperador. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from ecordell and njhale February 1, 2022 21:05
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 1, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aemperador
To complete the pull request process, please assign dinhxuanvu after the PR has been reviewed.
You can assign the PR to them by writing /assign @dinhxuanvu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

asmflags: *build-asmflags
gcflags: *build-gcflags
ldflags: *build-ldflags
- id: darwin-amd64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't build macos binaries via goreleaser because the macos compiler is not available (and not licensed for use) on Linux.

So the macos binary builds need to continue to be run on macos-latest machines via the github action. And then rather than using goreleaser's github release integration, we'll have to tie all this together via github actions to create the release and upload the assets, similar to what we're doing in .github/workflows/release.yaml

@joelanford
Copy link
Member

Closing since we merged #914 instead. Thanks for helping out!

@joelanford joelanford closed this Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants